Conversation
7b24722 to
7678150
Compare
|
Cannot properly replicate arm issues on my m1 mac now, likely due to rosetta. Will run another round of tests on the pis after the weekend. @danehans should this PR also update the quickstart with the k8s-staging-ingressconformance/echoserver, replacing httpbin? |
Signed-off-by: danehans <daneyonhansen@gmail.com>
7678150 to
8c155a5
Compare
@fredzach I want to keep this PR focused on the HTTP routing user doc changes. Would you like to submit a PR for updating the Quickstart image? |
|
Removing "Draft" since #571 adds .md support. |
youngnick
left a comment
There was a problem hiding this comment.
LGTM with one minor formtting nit.
| an HTTPRoute must be configured with `parentRefs` which reference the parent Gateway(s) that it should be attached to. | ||
| An HTTPRoute can match against a [single set of hostnames][spec]. These hostnames are matched before any other matching | ||
| within the HTTPRoute takes place. Since `example.com`, `foo.example.com`, and `bar.example.com` are separate hosts with | ||
| different routing requirements, each is deployed as its own HTTPRoute - `example-route, ``foo-route`, and `bar-route`. |
There was a problem hiding this comment.
| different routing requirements, each is deployed as its own HTTPRoute - `example-route, ``foo-route`, and `bar-route`. | |
| different routing requirements, each is deployed as its own HTTPRoute - `example-route`, `foo-route`, and `bar-route`. |
|
@youngnick merging since the PR is already approved and I'll resolve your feedback shortly in a follow-on PR. |
xref: #501
Signed-off-by: danehans daneyonhansen@gmail.com