fix: incorrect level of envoy-gateway configmap vars#711
Merged
arkodg merged 3 commits intoenvoyproxy:mainfrom Nov 9, 2022
Merged
fix: incorrect level of envoy-gateway configmap vars#711arkodg merged 3 commits intoenvoyproxy:mainfrom
arkodg merged 3 commits intoenvoyproxy:mainfrom
Conversation
7a357e4 to
bb9e57f
Compare
Signed-off-by: bitliu <bitliu@tencent.com>
danehans
reviewed
Nov 8, 2022
Contributor
danehans
left a comment
There was a problem hiding this comment.
A couple of small nits. Otherwise /lgtm.
Codecov Report
@@ Coverage Diff @@
## main #711 +/- ##
==========================================
- Coverage 63.29% 63.03% -0.26%
==========================================
Files 47 47
Lines 5806 5806
==========================================
- Hits 3675 3660 -15
- Misses 1902 1914 +12
- Partials 229 232 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arkodg
reviewed
Nov 8, 2022
| require.Equal(t, tc.out, eg) | ||
| } else { | ||
| require.Error(t, err, "An error was expected") | ||
| require.Equal(t, (!reflect.DeepEqual(tc.out, eg) || err != nil), true) |
arkodg
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: incorrect level of envoy-gateway configmap vars
Signed-off-by: bitliu bitliu@tencent.com