Codecov Report

Merging #666 (37381a4) into main (592863a) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
- Coverage   62.82%   62.79%   -0.04%     
==========================================
  Files          47       47              
  Lines        5762     5762              
==========================================
- Hits         3620     3618       -2     
  Misses       1912     1912              
- Partials      230      232       +2     

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arkodg can you provide additional context on how this change supports GRPCRoute?

From Envoy's gRPC docs:

At the transport layer it uses HTTP/2 or above for request/response multiplexing.

Does this mean gRPC-Web will not be supported for GRPCRoute?

@arkodg can you provide additional context on how this change supports GRPCRoute?

From Envoy's gRPC docs:

At the transport layer it uses HTTP/2 or above for request/response multiplexing.

Does this mean gRPC-Web will not be supported for GRPCRoute?

• this knob could be used to filter for h2 and h2c upstream connections in the listener and will mainly be used to add some more fields in the cluster so the upstream connection is http2
• this sadly won't support grpc-web, I think of that feature as a seperate transcoding feature,
  we might be able to bundle it up and also enable grpc-web on the same downstream connection if the grpc web filter allows grpc traffic to flow through seamlessly
  @lizan do have any datapoints around this ?