Merged
Conversation
08d17dc to
a5f47c7
Compare
Signed-off-by: bitliu <bitliu@tencent.com>
Codecov Report
@@ Coverage Diff @@
## main #530 +/- ##
==========================================
- Coverage 62.72% 62.61% -0.12%
==========================================
Files 42 42
Lines 4496 4496
==========================================
- Hits 2820 2815 -5
- Misses 1532 1536 +4
- Partials 144 145 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
Looks OK to me, but I know that @danehans was hesitant to create an |
Member
Author
|
Thanks for this comment @LukeShu, yes, so this can wait until we got another provider, and we can do better abstraction. |
arkodg
reviewed
Oct 13, 2022
Contributor
|
should be fine to get this in, and iterate, thanks for adding this @Xunzhuo |
arkodg
approved these changes
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve: #182
Since this is a backlog issue, I will work on this after releasing v0.2.0.
Signed-off-by: bitliu bitliu@tencent.com