feat: set envoyproxy image to envoy-dev latest in main#712
feat: set envoyproxy image to envoy-dev latest in main#712arkodg merged 1 commit intoenvoyproxy:mainfrom
Conversation
danehans
left a comment
There was a problem hiding this comment.
[decision]: Do we expose the Envoy image version to users?
There was a problem hiding this comment.
- Since this is a user-facing API, I think it's better to s/in the Infra IR to deploy EnvoyProxy/for the managed Envoy proxies/
- IMO this field does not belong in the
Gatewaystruct` and I'm unsure if we want to expose the Envoy version to users. Making the version configurable can create a support nightmare of neverending EG<>Envoy combinations. IMO we release EG with the latest Envoy release and users upgrade EG if they need a newer version of Envoy. Thoughts @arkodg @LukeShu @skriss @youngnick @AliceProxy? - Add an empty line before
+optional.
There was a problem hiding this comment.
+1 to delaying this API change until users really need it. Post v0.3.0 an exercise we will need to do is
- what level of customizations do we need to provide for
- xds
- EG platform/k8s deployment/service
- Envoy platform/k8s deployment/service
- how do we expose these customizations
There was a problem hiding this comment.
Thanks for comments @danehans @arkodg, this PR is WIP state, and the approach in this PR is what I want to have a discussion. I think you are right, API changes should be careful. But for resolving the linked issue, if we want to update the envoyproxy image in our release CI or by make targets, I think it should be updated in the configuration, otherwise we can only change the default value of envoy Image. It is a const, feel a bit weird to change it repeatly.
There was a problem hiding this comment.
I think it should be updated in the configuration...
If we expose the Envoy image here, then users can change the image. I don't think we should do this due to the concerns I stated in #712 (comment).
There was a problem hiding this comment.
There was a problem hiding this comment.
We keep the const to the envoy-dev:latest in main. Everytime we release, we update the const to the appropriate envoy release version.
Yes.
Signed-off-by: bitliu <bitliu@tencent.com>
7a357e4 to
2b78ff8
Compare
Codecov Report
@@ Coverage Diff @@
## main #712 +/- ##
=======================================
Coverage 63.29% 63.29%
=======================================
Files 47 47
Lines 5806 5806
=======================================
Hits 3675 3675
Misses 1902 1902
Partials 229 229
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Fixes: #672
Signed-off-by: bitliu bitliu@tencent.com