Skip to content

Fixes Envoy Deployment Ref in Dev Doc#722

Merged
Xunzhuo merged 1 commit intoenvoyproxy:mainfrom
danehans:dev_doc_fix
Nov 11, 2022
Merged

Fixes Envoy Deployment Ref in Dev Doc#722
Xunzhuo merged 1 commit intoenvoyproxy:mainfrom
danehans:dev_doc_fix

Conversation

@danehans
Copy link
Copy Markdown
Contributor

@danehans danehans commented Nov 10, 2022

Previously:

$ export ENVOY_DEPLOYMENT=$(kubectl get deploy -n envoy-gateway-system --selector=gateway.envoyproxy.io/owning-gateway-namespace=default,gateway.envoyproxy.io/owning-gateway-name=eg -o jsonpath='{.items[0].metadata.name}')

$ echo $ENVOY_DEPLOYMENT
envoy-default-eg-64656661

$ kubectl port-forward deploy/envoy-${ENVOY_DEPLOYMENT} -n envoy-gateway-system 19000:19000

Error from server (NotFound): deployments.apps "envoy-envoy-default-eg-64656661" not found

After removing envoy-:

$ kubectl port-forward deploy/${ENVOY_DEPLOYMENT} -n envoy-gateway-system 19000:19000

Forwarding from 127.0.0.1:19000 -> 19000
Forwarding from [::1]:19000 -> 19000

Signed-off-by: danehans daneyonhansen@gmail.com

@danehans
Fixes Dev Doc Deployment Ref
474a3bc 
Signed-off-by: danehans <daneyonhansen@gmail.com>
@danehans danehans added kind/bug Something isn't working documentation Improvements or additions to documentation labels Nov 10, 2022
@danehans danehans requested a review from a team as a code owner November 10, 2022 22:13
@danehans danehans added this to the 0.3.0-rc.1 milestone Nov 10, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 10, 2022 •
edited
Loading

Codecov Report

Merging #722 (474a3bc) into main (ee75e3b) will increase coverage by 0.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
+ Coverage   63.64%   64.06%   +0.42%     
==========================================
  Files          47       47              
  Lines        5927     5927              
==========================================
+ Hits         3772     3797      +25     
+ Misses       1919     1897      -22     
+ Partials      236      233       -3
Impacted Files Coverage Δ
internal/provider/kubernetes/tlsroute.go 61.67% <0.00%> (+2.20%) ⬆️
internal/provider/kubernetes/httproute.go 67.48% <0.00%> (+8.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xunzhuo Xunzhuo merged commit c1f2585 into envoyproxy:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkodg arkodg arkodg approved these changes

@Xunzhuo Xunzhuo Xunzhuo approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation kind/bug Something isn't working

Projects

None yet

Milestone

0.3.0-rc.1

Development

Successfully merging this pull request may close these issues.

4 participants

@danehans @codecov-commenter @arkodg @Xunzhuo