Adds TLS Termination Support#519
Merged
danehans merged 3 commits intoenvoyproxy:mainfrom Oct 11, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 62.72% 60.60% -2.12%
==========================================
Files 42 42
Lines 4496 4699 +203
==========================================
+ Hits 2820 2848 +28
- Misses 1532 1698 +166
- Partials 144 153 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arkodg
reviewed
Oct 8, 2022
Contributor
| will need to be enhanced with a function that scrubs outs the key material, deleting it in this PR and raising a issue to track it should unblock this PR. |
Contributor
Author
|
@arkodg regagarding #519 (comment), removed. |
arkodg
reviewed
Oct 8, 2022
arkodg
reviewed
Oct 8, 2022
arkodg
reviewed
Oct 8, 2022
cda5c81 to
3d00fee
Compare
arkodg
reviewed
Oct 10, 2022
arkodg
reviewed
Oct 10, 2022
arkodg
reviewed
Oct 11, 2022
arkodg
previously approved these changes
Oct 11, 2022
Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: danehans <daneyonhansen@gmail.com>
arkodg
approved these changes
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for TLS termination.
Fixes #471