docs: correcting route ref, system design#570
Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom Oct 14, 2022
fredgineer:patch-1
Merged
docs: correcting route ref, system design#570arkodg merged 1 commit intoenvoyproxy:mainfrom fredgineer:patch-1
arkodg merged 1 commit intoenvoyproxy:mainfrom
fredgineer:patch-1
Conversation
Signed-off-by: Fredrik Geijer Haeggström <fredrik.g.haeggstrom@gmail.com>
arkodg
approved these changes
Oct 14, 2022
Contributor
arkodg
left a comment
There was a problem hiding this comment.
thanks for correcting this !
Codecov Report
@@ Coverage Diff @@
## main #570 +/- ##
==========================================
- Coverage 60.33% 60.20% -0.13%
==========================================
Files 45 45
Lines 5564 5564
==========================================
- Hits 3357 3350 -7
- Misses 2001 2006 +5
- Partials 206 208 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confused by the documented cardinality of Gateway components and their Proxy representations, I deployed the gateway with two HTTPRoutes and did a config dump of the gateway. The docs
Routerefers to the proxyRouteConfiguration, but it should indeed refer toRoute.Signed-off-by: Fredrik Geijer Haeggström fredrik.g.haeggstrom@gmail.com