Skip to content

feat: implement liveness and readiness probes#524

Merged
arkodg merged 5 commits intoenvoyproxy:mainfrom
Xunzhuo:feat-liveness
Oct 11, 2022
Merged

feat: implement liveness and readiness probes#524
arkodg merged 5 commits intoenvoyproxy:mainfrom
Xunzhuo:feat-liveness

Conversation

@Xunzhuo
Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo commented Oct 9, 2022

Resolves: #235

Tested locally and works well:

image

image

Signed-off-by: bitliu bitliu@tencent.com

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 9, 2022

Codecov Report

Merging #524 (f27f633) into main (b9ed6df) will decrease coverage by 0.11%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   61.93%   61.81%   -0.12%     
==========================================
  Files          45       45              
  Lines        5343     5350       +7     
==========================================
- Hits         3309     3307       -2     
- Misses       1840     1847       +7     
- Partials      194      196       +2     
Impacted Files Coverage Δ
internal/provider/kubernetes/kubernetes.go 48.00% <50.00%> (-5.49%) ⬇️
internal/provider/kubernetes/gatewayclass.go 73.18% <0.00%> (-2.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xunzhuo Xunzhuo marked this pull request as ready for review October 9, 2022 04:17
@Xunzhuo Xunzhuo requested a review from a team as a code owner October 9, 2022 04:17
@Xunzhuo Xunzhuo force-pushed the feat-liveness branch 2 times, most recently from 7d60f9e to 185f4aa Compare October 9, 2022 07:05
Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: bitliu <bitliu@tencent.com>
arkodg
arkodg previously approved these changes Oct 11, 2022
Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com>
@arkodg arkodg merged commit 4d8d9f6 into envoyproxy:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement liveness and readiness probes on the Deployment

3 participants