Skip to content

translator: add accesslog#704

Merged
arkodg merged 3 commits intoenvoyproxy:mainfrom
zirain:xds-accesslog
Nov 9, 2022
Merged

translator: add accesslog#704
arkodg merged 3 commits intoenvoyproxy:mainfrom
zirain:xds-accesslog

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Nov 7, 2022

fixes: #684

output as follow:

[2022-11-07T01:44:50.341Z] "GET /get HTTP/1.1" 200 - 0 426 0 0 "-" "curl/7.58.0" "f5dec879-4c62-4a7d-a555-d7c044c9d5f0" "www.example.com" "10.96.77.203:3000"

this's not for #699

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain zirain requested a review from a team as a code owner November 7, 2022 01:51
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Nov 7, 2022

/retest

@zirain zirain closed this Nov 7, 2022
@zirain zirain reopened this Nov 7, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 7, 2022

Codecov Report

Merging #704 (ac8be62) into main (54d44d5) will increase coverage by 0.07%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
+ Coverage   63.68%   63.75%   +0.07%     
==========================================
  Files          47       47              
  Lines        5749     5777      +28     
==========================================
+ Hits         3661     3683      +22     
- Misses       1864     1867       +3     
- Partials      224      227       +3     
Impacted Files Coverage Δ
internal/xds/translator/listener.go 79.18% <78.57%> (-0.09%) ⬇️
internal/provider/kubernetes/tlsroute.go 59.47% <0.00%> (-0.89%) ⬇️
internal/provider/kubernetes/gatewayclass.go 75.36% <0.00%> (+1.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zirain zirain closed this Nov 7, 2022
@zirain zirain reopened this Nov 7, 2022
@danehans danehans added the area/api API-related issues label Nov 7, 2022
@danehans danehans added this to the Backlog milestone Nov 7, 2022
@arkodg arkodg removed the area/api API-related issues label Nov 7, 2022
@arkodg arkodg modified the milestones: Backlog, 0.3.0-rc.1 Nov 7, 2022
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Nov 8, 2022

@zirain lint is failing

/internal/xds/translator/accesslog.go:18: doesnt ==> doesn't, does not

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks again @zirain !

@arkodg arkodg merged commit 0446430 into envoyproxy:main Nov 9, 2022
@zirain zirain deleted the xds-accesslog branch November 9, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable access logging for xds components

4 participants