Skip to content

fix: cobra mismatched comments#525

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
Xunzhuo:fix-comment
Oct 10, 2022
Merged

fix: cobra mismatched comments#525
arkodg merged 1 commit intoenvoyproxy:mainfrom
Xunzhuo:fix-comment

Conversation

@Xunzhuo
Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo commented Oct 9, 2022

Signed-off-by: bitliu bitliu@tencent.com

Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo marked this pull request as ready for review October 9, 2022 07:12
@Xunzhuo Xunzhuo requested a review from a team as a code owner October 9, 2022 07:12
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #525 (b783cba) into main (b8f234b) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
+ Coverage   62.72%   62.78%   +0.06%     
==========================================
  Files          42       42              
  Lines        4496     4496              
==========================================
+ Hits         2820     2823       +3     
+ Misses       1532     1530       -2     
+ Partials      144      143       -1     
Impacted Files Coverage Δ
internal/cmd/certgen.go 12.82% <ø> (ø)
internal/cmd/versions.go 28.57% <ø> (ø)
internal/provider/kubernetes/gatewayclass.go 73.18% <0.00%> (+2.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@arkodg arkodg merged commit 34afca0 into envoyproxy:main Oct 10, 2022
@Xunzhuo Xunzhuo deleted the fix-comment branch October 10, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants