Rebase branch#1
Merged
gildaswise merged 1751 commits intogildaswise:gildaswise-search-delegatefrom Sep 10, 2020
Merged
Conversation
* add run_if property for existing try builders * update * update readme
This wires up the new WindowProc delegation system that allows plugins to handle top-level window messages (e.g., to control resize behavior). Fixes #53168
* Minor adjustment for engine change, and rev template version * whitespace fix
The remaining uses of this pattern were all due to wanting to have the child's slot when `Element.forgetChild()` was called. However, when that method is called, the child's `slot` value is still valid in the context of the parent, so the uses can just use `child.slot`. This is the final round of cleanup from the fallout of #63269
More work towards removal of mockito to facilitate strong null safety tests. #62886
…and get the underlying webDriver (#65051)
…cale gestures (#64267) Currently the framework uses fairly large "hit slop" values to disambiguate taps from drags/pans. This makes sense on touch devices where the interaction is not very precise, on mice however it can feel as if the UI is lagging. This is immediately noticeable on our infra dashboard, where it takes almost half of a grid square of drag before the actual drag kicks in. One potential solution is to always use smaller constants depending on whether the interaction is mouse or touch based. The only reasonable choice is to use the pointer device kind and not target platform - same platform can have different input sources. This requires exposing the pointer device kind in a few new places in several of the gesture detectors, and using the enum to compute the correct hit slop from an expanded set of constants. This almost works, however there are a few places (notably ListViews) which uses the touch hit slop as a default value in scroll physics. It does not seem like it will be easy to disambiguate a user provided scroll physics constant from the default and/or adjust it somehow - this might require significant changes to scroll physics which I have left out of this PR. This PR does not adjust: kTouchSlop used in scroll_physics.dart's minFlingDistance kTouchSlop used in PrimaryPointerGestureRecognizer/LongPressGestureRecognizer
Integration tests must only go through the real file system/process manager/platform. The global indirection makes this code harder to understand than if it directly referred to the concrete instances that are being used. Update the integration shard to use a const instance of a LocalFIleSystem, LocalProcessManager, and LocalPlatform. Remove global usage and apply testWithoutContext.
I modified TextAlign docs because the descriptions of TextAlign.center and Center Widget are so similar that they cause confusion. Fixes #5805
…type wasn't changed (#64855)
* migrate widget to nullsafety
* remove double blank line after license
* address review comments in actions.dart
* nullable ObjectKey.value
* use local variable oldElement
* make State.build non-nullable
* make State.context non-nullable
* newline at eof
* make ProxyWidget.child non-nullable
* make _InactiveElements.debugContains non-nullable
* make Element.depth non-nullable
* make ProxyElement.build non-nullable
* make StatefulElement.state non-nullable
* remove 'Notice that'
* avoid cast of list in RenderObjectElement.updateChildren
* make IndexedSlot.value non-nullable
* avoid cast of list in MultiChildRenderObjectElement.mount
* make some WidgetsApp parameters non-nullable
* hitTest take non-nullable position
* make ScrollableState.position non-nullable
* use _pixels instead of pixels
* make ViewportOffset.pixels non-nullable
* make param and return type of IndexedWidgetBuilder non-nullable
* unused_import
* make context param non-nullable for Builder in animated_list.dart
* make ScrollMetrics.viewportDimension non-nullable
* make ScrollMetrics.{min,max}ScrollExtent non-nullable
* make _Location.file non-nullable
* _WidgetForTypeTests.createElement throw UnimplementedError
* update _NullWidget.build error message
* make _ShortcutsState.manager non-nullable
* Fix childCount issues for NNBD
* fix childCount computation on web
* increase max value on js side to compute childCount
* make aspect parameter of dependOnInheritedWidgetOfExactType nullable
* merge has{min,max}ScrollExtent into hasScrollExtents
* update focus_manager.dart
* address review comments in icon.dart
* address review comments in image.dart
* address review comments in routes.dart
* address review comments in scroll_activity.dart
* update doc comments
* make UserScrollNotification.direction non-nullable and required
* rename hasScrollExtents to hasContentDimensions
* unnecessary late
Co-authored-by: Ian Hickson <ian@hixie.ch>
This is in preparation to enable the new mac builders. Bug: #65223
* 556cb23 Roll Skia from 6763a713f957 to d91cd6b5ee2b (3 revisions) (flutter/engine#20989) * b6a3c54 Roll Fuchsia Linux SDK from A0PKwETay... to gfAt63Ezd... (flutter/engine#21005) * cceb733 Roll Fuchsia Mac SDK from sih5f60Gt... to 9pfHLZEFU... (flutter/engine#21006) * 5539820 Roll Skia from d91cd6b5ee2b to a73a84f9b8e3 (1 revision) (flutter/engine#21007) * b4cc631 Roll Dart SDK from f3a9ca88b664 to e59935669cb0 (1 revision) (flutter/engine#21008) * 6cf0cc4 Roll Skia from a73a84f9b8e3 to d0fe7d37d678 (1 revision) (flutter/engine#21011) * 5b055bb Roll Skia from d0fe7d37d678 to 611a52108b01 (2 revisions) (flutter/engine#21012) * 575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (flutter/engine#20895) * 040a794 Roll Fuchsia Mac SDK from 9pfHLZEFU... to tUwahggJ8... (flutter/engine#21013) * 22cca4c Roll Dart SDK from e59935669cb0 to f745f9447ddf (1 revision) (flutter/engine#21014) * 539cb69 Roll Fuchsia Linux SDK from gfAt63Ezd... to Ta3F40BV6... (flutter/engine#21015) * 7d927dd Roll Dart SDK from f745f9447ddf to b88c06c314f4 (1 revision) (flutter/engine#21016) * 09a5bf7 Tweak the mdns error message (flutter/engine#20991) * d0d9ce6 Roll Fuchsia Linux SDK from Ta3F40BV6... to coVjRTWSf... (flutter/engine#21018) * 808bb85 Roll Fuchsia Mac SDK from tUwahggJ8... to TyNHQXzNU... (flutter/engine#21019) * 5aa6921 Roll Skia from 611a52108b01 to cd54c8385c31 (2 revisions) (flutter/engine#21021) * e7d558f Roll Dart SDK from b88c06c314f4 to 33b6c95936e0 (2 revisions) (flutter/engine#21023) * af90dd3 Roll Skia from cd54c8385c31 to c0d3495e1ee2 (12 revisions) (flutter/engine#21024) * f0fb74b Avoid crashing and display error if the process cannot be prepared for JIT mode Dart VM. (flutter/engine#20980) * 6a6c23a Roll Skia from c0d3495e1ee2 to cf1a4f50121f (6 revisions) (flutter/engine#21026) * 716dce0 Android 30r3 (flutter/engine#21025) * 7431070 Roll Dart SDK from 33b6c95936e0 to a2c9cae4dcd8 (1 revision) (flutter/engine#21027) * cef383d Roll Skia from cf1a4f50121f to 04b9443274cf (2 revisions) (flutter/engine#21028) * cf8c6b8 Update web lerpDouble to match C++ behaviour (flutter/engine#21010) * 6866675 Roll Skia from 04b9443274cf to b8ae7fa12aa0 (1 revision) (flutter/engine#21030) * c538f40 Roll Dart SDK from a2c9cae4dcd8 to ffbfa2000435 (1 revision) (flutter/engine#21031) * 89d34b0 Roll Skia from b8ae7fa12aa0 to 445c8ebcb710 (1 revision) (flutter/engine#21032) * 7766d2e Roll Fuchsia Mac SDK from TyNHQXzNU... to Phn3nF_BJ... (flutter/engine#21034) * e3de8d0 Roll Fuchsia Linux SDK from coVjRTWSf... to eBus_y4DN... (flutter/engine#21035) * beb7df5 Roll Skia from 445c8ebcb710 to f9d5940fef55 (3 revisions) (flutter/engine#21037) * f3a17b6 Roll Skia from f9d5940fef55 to 81c6d6eeb4cf (1 revision) (flutter/engine#21038) * bbcc495 Roll Dart SDK from ffbfa2000435 to 2e838b7b4503 (2 revisions) (flutter/engine#21039) * 61062fd Roll Skia from 81c6d6eeb4cf to 81606b5d9774 (5 revisions) (flutter/engine#21041) * f7c7b41 Revert "Enable lazy-async-stacks by-default in all modes (Take 3) (#20895)" (flutter/engine#21043)
Removes global variables and adds unit tests that can be copied for #65118
…art (#65435) * [flutter_tools] alternate the name of the dill file used for hot restart * switch alternative name to .swap
The Windows plugin CMake generation had code to ensure that the paths written to it used POSIX separators, but the Linux version didn't; that meant that plugin updates run on Windows machines would corrupt the generated (but checked in) Linux CMake file. This change shares that code so that both will use POSIX paths regardless of what OS they are generated on. Fixes #64591
* [gen_l10n] Support string list as preferred-supported-locales, as documented. * [gen_l10n] Convert preferredSupportedLocale to a list of strings. * [gen_l10n] Accept a multi option instead of a json string in the command line.
gildaswise
pushed a commit
that referenced
this pull request
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.