(insert|move|remove)ChildRenderObject Deprecation: Step 1 #64189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecates the following methods: * RenderObjectElement.insertChildRenderObject * RenderObjectElement.moveChildRenderObject * RenderObjectElement.removeChildRenderObject And replace them with the following methods: * RenderObjectElement.insertRenderObjectChild * RenderObjectElement.moveRenderObjectChild * RenderObjectElement.removeRenderObjectChild The reason for the deprecation is to provide the `oldSlot` argument to the [moveRenderObjectChild] method (such an argument was missing from the now-deprecated [moveChildRenderObject] method) and the `slot` argument to the [removeRenderObjectChild] method (such an argument was missing from the now-deprecated [removeChildRenderObject] method). While no argument was added to [insertRenderObjectChild], the name change (and corresponding deprecation) was made to maintain naming parity with the other two methods. This initial step does not update or remove any of the `slotToChild` patterns that exist in the framework. This work is being separated into two commits in case something needs to be reverted to minimize the scope of each commit. See #63269 for more info
goderbauer
approved these changes
Aug 19, 2020
Member
goderbauer
left a comment
There was a problem hiding this comment.
LGTM once all checks pass.
Contributor
|
This is a breaking change. Internal chart library compilation is failing with: We need to soft land this internally and come up with a breaking change document. |
mehmetf
added a commit
that referenced
this pull request
Aug 20, 2020
Contributor
Author
|
Soft land step is cl/327627478, and re-application of this PR is #64254 |
tvolkert
added a commit
that referenced
this pull request
Aug 20, 2020
Member
|
Technically, because of the google3 breakage this is a breaking change now per https://github.com/flutter/flutter/wiki/Tree-hygiene#1-determine-if-your-change-is-a-breaking-change. Maybe we should publish a quick migration guide for it on https://flutter.dev/docs/release/breaking-changes. |
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
) * (insert|move|remove)ChildRenderObject Deprecation: Step 1 This deprecates the following methods: * RenderObjectElement.insertChildRenderObject * RenderObjectElement.moveChildRenderObject * RenderObjectElement.removeChildRenderObject ...and replaces them with the following methods: * RenderObjectElement.insertRenderObjectChild * RenderObjectElement.moveRenderObjectChild * RenderObjectElement.removeRenderObjectChild The reason for the deprecation is to provide the `oldSlot` argument to the `moveRenderObjectChild` method (such an argument was missing from the now-deprecated `moveChildRenderObject` method) and the `slot` argument to the `removeRenderObjectChild` method (such an argument was missing from the now-deprecated `removeChildRenderObject` method). While no argument was added to `insertRenderObjectChild`, the name change (and corresponding deprecation) was made to maintain naming parity with the other two methods. This initial step does not update or remove any of the `slotToChild` patterns that exist in the framework. This work is being separated into two commits in case something needs to be reverted to minimize the scope of each commit. See flutter#63269 for more info
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
…utter#64189)" (flutter#64249) This reverts commit 21cfed3.
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
…lutter#64189)" (flutter#64254) This reverts commit ce40de6. (this re-applies flutter#64189 by reverting flutter#64249)
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
) * (insert|move|remove)ChildRenderObject Deprecation: Step 1 This deprecates the following methods: * RenderObjectElement.insertChildRenderObject * RenderObjectElement.moveChildRenderObject * RenderObjectElement.removeChildRenderObject ...and replaces them with the following methods: * RenderObjectElement.insertRenderObjectChild * RenderObjectElement.moveRenderObjectChild * RenderObjectElement.removeRenderObjectChild The reason for the deprecation is to provide the `oldSlot` argument to the `moveRenderObjectChild` method (such an argument was missing from the now-deprecated `moveChildRenderObject` method) and the `slot` argument to the `removeRenderObjectChild` method (such an argument was missing from the now-deprecated `removeChildRenderObject` method). While no argument was added to `insertRenderObjectChild`, the name change (and corresponding deprecation) was made to maintain naming parity with the other two methods. This initial step does not update or remove any of the `slotToChild` patterns that exist in the framework. This work is being separated into two commits in case something needs to be reverted to minimize the scope of each commit. See flutter#63269 for more info
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…utter#64189)" (flutter#64249) This reverts commit 21cfed3.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…lutter#64189)" (flutter#64254) This reverts commit ce40de6. (this re-applies flutter#64189 by reverting flutter#64249)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This deprecates the following methods:
... and replaces them with the following methods:
The reason for the deprecation is to provide the
oldSlotargument tothe
moveRenderObjectChildmethod (such an argument was missing fromthe now-deprecated
moveChildRenderObjectmethod) and theslotargument to the
removeRenderObjectChildmethod (such an argument wasmissing from the now-deprecated
removeChildRenderObjectmethod). Whileno argument was added to
insertRenderObjectChild, the name change (andcorresponding deprecation) was made to maintain naming parity with the
other two methods.
This initial step does not update or remove any of the
slotToChildpatterns that exist in the framework. This work is being separated
into two commits in case something needs to be reverted to minimize
the scope of each commit.
Related Issues
See #63269 for more info
Tests
I added the following tests:
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].