Skip to content

Revert "(insert|move|remove)ChildRenderObject Deprecation: Step 1" #64249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mehmetf merged 1 commit into from
Aug 20, 2020
Merged

Revert "(insert|move|remove)ChildRenderObject Deprecation: Step 1" #64249

mehmetf merged 1 commit into from
Aug 20, 2020

Conversation

@mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Aug 20, 2020 •
edited
Loading

Reverts #64189

This was a breaking change. Internal chart library compilation is failing with:

  This method overrides a method annotated as '@mustCallSuper' in 'RenderObjectElement', but doesn't invoke the overridden method. #must_call_super

We need to soft land this internally and come up with a breaking change document.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 20, 2020
@mehmetf mehmetf merged commit ce40de6 into master Aug 20, 2020
@mehmetf mehmetf deleted the revert-64189-render_object_element branch August 20, 2020 14:31
tvolkert added a commit that referenced this pull request Aug 20, 2020
@tvolkert
Revert "Revert "(insert|move|remove)ChildRenderObject Deprecation: St…
622cf13 
…ep 1 (#64189)" (#64249)"

This reverts commit ce40de6.
@tvolkert tvolkert mentioned this pull request Aug 20, 2020
Merged
tvolkert added a commit that referenced this pull request Aug 20, 2020
@tvolkert
Re-apply "(insert|move|remove)ChildRenderObject Deprecation: Step 1 (#…
4d8934a 
…64189)" (#64254)

This reverts commit ce40de6.

(this re-applies #64189 by reverting #64249)
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
@mehmetf @smadey
Revert "(insert|move|remove)ChildRenderObject Deprecation: Step 1 (fl…
1beff1e 
…utter#64189)" (flutter#64249)

This reverts commit 21cfed3.
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
@tvolkert @smadey
Re-apply "(insert|move|remove)ChildRenderObject Deprecation: Step 1 (f…
3fdad60 
…lutter#64189)" (flutter#64254)

This reverts commit ce40de6.

(this re-applies flutter#64189 by reverting flutter#64249)
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@mehmetf @mingwandroid
Revert "(insert|move|remove)ChildRenderObject Deprecation: Step 1 (fl…
3aff375 
…utter#64189)" (flutter#64249)

This reverts commit 21cfed3.
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@tvolkert @mingwandroid
Re-apply "(insert|move|remove)ChildRenderObject Deprecation: Step 1 (f…
5e97a8a 
…lutter#64189)" (flutter#64254)

This reverts commit ce40de6.

(this re-applies flutter#64189 by reverting flutter#64249)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mehmetf @googlebot