Skip to content

Remove windows_docs.#64277

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
godofredoc:remove_win_docs
Aug 21, 2020
Merged

Remove windows_docs.#64277
fluttergithubbot merged 1 commit intoflutter:masterfrom
godofredoc:remove_win_docs

Conversation

@godofredoc
Copy link
Contributor

Description

The builder was removed but it was not removed from the prod builders
file and it is still showing up as all blue column in the dashboard.

Related Issues

None

Tests

N/A

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

The builder was removed but it was not removed from the prod builders
file and it is still showing up as all blue column in the dashboard.
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 20, 2020
@godofredoc godofredoc requested a review from keyonghan August 20, 2020 20:55
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite hostonly_devicelab_tests-2-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 1cd6694 into flutter:master Aug 21, 2020
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
@godofredoc godofredoc deleted the remove_win_docs branch October 18, 2021 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants