Skip to content

Add run_if property for existing LUCI try builders#64180

Merged
keyonghan merged 3 commits intoflutter:masterfrom
keyonghan:run_if_try_builders
Aug 21, 2020
Merged

Add run_if property for existing LUCI try builders#64180
keyonghan merged 3 commits intoflutter:masterfrom
keyonghan:run_if_try_builders

Conversation

@keyonghan
Copy link
Contributor

With Cocoon's filtering support: flutter/cocoon#917, run_if in this PR enables to trigger only corresponding builders rather than all.

This will somewhat relieve the execution burden of try pool.

Related issue: #62841

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 19, 2020
Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a noop until we land the code to act on it?

@keyonghan
Copy link
Contributor Author

Is this a noop until we land the code to act on it?

No. Existing cocoon will just ignore the run_if without flutter/cocoon#917.

Copy link
Contributor

@digiter digiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan keyonghan merged commit c98a64f into flutter:master Aug 21, 2020
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
* add run_if property for existing try builders

* update

* update readme
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
* add run_if property for existing try builders

* update

* update readme
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
@keyonghan keyonghan deleted the run_if_try_builders branch April 25, 2022 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants