Skip to content

Add null safety migration annotations.#64227

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
Hixie:nnbd
Aug 21, 2020
Merged

Add null safety migration annotations.#64227
fluttergithubbot merged 1 commit intoflutter:masterfrom
Hixie:nnbd

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Aug 20, 2020

This adds annotations to prepare the following files for migration:

  • rendering/animated_size.dart
  • rendering/binding.dart
  • rendering/box.dart
  • rendering/custom_layout.dart
  • rendering/custom_paint.dart
  • rendering/debug.dart
  • rendering/debug_overflow_indicator.dart
  • rendering/editable.dart
  • rendering/error.dart
  • rendering/flex.dart
  • rendering/flow.dart

(The rendering directory, alphabetically up to flow.dart.)

@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 20, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 20, 2020
@Hixie
Copy link
Contributor Author

Hixie commented Aug 20, 2020

This brings me back to the days where we were setting up method generics before they were allowed...

@Hixie
Copy link
Contributor Author

Hixie commented Aug 20, 2020

cc @goderbauer

goderbauer
goderbauer approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/rendering/flex.dart Outdated
Comment on lines 551 to 553
Copy link
Member

@goderbauer goderbauer Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these two could be late final?

packages/flutter/lib/src/rendering/flex.dart Outdated
Copy link
Member

@goderbauer goderbauer Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

late final?

packages/flutter/lib/src/rendering/flex.dart Outdated
Comment on lines 883 to 887
Copy link
Member

@goderbauer goderbauer Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

late final?

packages/flutter/lib/src/rendering/custom_paint.dart Outdated
Copy link
Member

@goderbauer goderbauer Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it also int/*!*/?

Copy link
Member

@goderbauer goderbauer Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is that inferred by the tool?

Copy link
Contributor Author

@Hixie Hixie Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inferred

packages/flutter/lib/src/rendering/box.dart Outdated
Copy link
Member

@goderbauer goderbauer Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably, _IntrinsicDimensionsCacheEntry would also be /*!*/ ?

Copy link
Contributor Author

@Hixie Hixie Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow it got that right

@goderbauer
Copy link
Member

goderbauer commented Aug 20, 2020

Looks like a test is failing, though.

@Hixie Hixie force-pushed the nnbd branch 3 times, most recently from ccc1a5c to 0a03a39 Compare August 20, 2020 21:23
@Hixie
Add null safety migration annotations.
bd8c2dd 
This adds annotations to prepare the following files for migration:

* rendering/animated_size.dart
* rendering/binding.dart
* rendering/box.dart
* rendering/custom_layout.dart
* rendering/custom_paint.dart
* rendering/debug.dart
* rendering/debug_overflow_indicator.dart
* rendering/editable.dart
* rendering/error.dart
* rendering/flex.dart
* rendering/flow.dart

(i.e. the rendering directory, alphabetically up to flow.dart.)
@Hixie
Copy link
Contributor Author

Hixie commented Aug 20, 2020

Updated as suggested

goderbauer
goderbauer approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Aug 20, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux web_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 93395b4 into flutter:master Aug 21, 2020
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
@Hixie @smadey
Add null safety migration annotations. (flutter#64227)
30e9844
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@Hixie @mingwandroid
Add null safety migration annotations. (flutter#64227)
eda9042
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hixie @goderbauer @fluttergithubbot @googlebot