Skip to content

Fix placement for SnackBarBehavior.floating#64268

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
Piinks:snackPlacement
Aug 20, 2020
Merged

Fix placement for SnackBarBehavior.floating#64268
fluttergithubbot merged 1 commit intoflutter:masterfrom
Piinks:snackPlacement

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Aug 20, 2020

Description

This fixes the placement of floating SnackBars to land within a safe interactive area.
SnackBarBehavior.fixed already accounts for SafeArea, and so is unaffected:

if (!isFloatingSnackBar) {

The floating behavior is not automatically wrapped in a SafeArea because its placement is dependent on other Scaffold elements, like the floating action button.

Related Issues

Fixes #64194

Tests

Floating SnackBar is placed within a SafeArea.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 20, 2020
@Piinks Piinks added a: quality A truly polished experience c: regression It was better in the past than it is now labels Aug 20, 2020
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fluttergithubbot fluttergithubbot merged commit 618ab7d into flutter:master Aug 20, 2020
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: quality A truly polished experience c: regression It was better in the past than it is now f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SnackBarBehavior.floating does not account for safe area

4 participants