Skip to content

Update Windows template for wrapper file change#64173

Merged
stuartmorgan-g merged 4 commits intoflutter:masterfrom
stuartmorgan-g:windows-wrapper-file-change
Aug 21, 2020
Merged

Update Windows template for wrapper file change#64173
stuartmorgan-g merged 4 commits intoflutter:masterfrom
stuartmorgan-g:windows-wrapper-file-change

Conversation

@stuartmorgan-g
Copy link
Contributor

Description

A specific implementation file in the C++ wrapper was replaced with a more future-proof catch-all implementation file; this updates the template to use it instead so the old file can be remove from the engine.

Related Issues

None.

Tests

I added the following tests: None.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 19, 2020
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@stuartmorgan-g stuartmorgan-g merged commit 8489d46 into flutter:master Aug 21, 2020
@stuartmorgan-g stuartmorgan-g deleted the windows-wrapper-file-change branch August 21, 2020 00:36
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
* Minor adjustment for engine change, and rev template version

* whitespace fix
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
* Minor adjustment for engine change, and rev template version

* whitespace fix
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants