Update Windows template for wrapper file change#64173
Merged
stuartmorgan-g merged 4 commits intoflutter:masterfrom Aug 21, 2020
Merged
Update Windows template for wrapper file change#64173stuartmorgan-g merged 4 commits intoflutter:masterfrom
stuartmorgan-g merged 4 commits intoflutter:masterfrom
Conversation
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
* Minor adjustment for engine change, and rev template version * whitespace fix
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
* Minor adjustment for engine change, and rev template version * whitespace fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A specific implementation file in the C++ wrapper was replaced with a more future-proof catch-all implementation file; this updates the template to use it instead so the old file can be remove from the engine.
Related Issues
None.
Tests
I added the following tests: None.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.