Skip to content

updated_title_property_apidocs#63884

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
Aman9026:patch-2
Sep 8, 2020
Merged

updated_title_property_apidocs#63884
fluttergithubbot merged 2 commits intoflutter:masterfrom
Aman9026:patch-2

Conversation

@Aman9026
Copy link
Contributor

@Aman9026 Aman9026 commented Aug 16, 2020

Description

updated title property apidoc for web for solving issue #57673

Related Issues

Fixes #57673

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 16, 2020
@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 16, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer goderbauer added the platform-web Web applications specifically label Aug 17, 2020
goderbauer
goderbauer reviewed Aug 19, 2020
View reviewed changes
packages/flutter/lib/src/widgets/app.dart Outdated
Copy link
Member

@goderbauer goderbauer Aug 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better: "On the web it is used as the page title, which shows up in the browser's list of open tabs."

Copy link
Contributor Author

@Aman9026 Aman9026 Aug 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goderbauer Done 😄

goderbauer
goderbauer approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Aug 26, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite testonly_devicelab_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Aug 27, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite testonly_devicelab_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor

Piinks commented Sep 2, 2020

Hey @Aman9026 can you update your branch with the latest from master? That should resolve the failing checks here. Thanks!

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ documentation labels Sep 2, 2020
@Aman9026
updated_title_property_apidocs
d9ab016 
updated title property apidocs for adding details about the title property on web
@Aman9026
Updated title api docs for web
9f9e301 
updated title property apidoc for web for solving issue flutter#57673
@Aman9026
Copy link
Contributor Author

Aman9026 commented Sep 3, 2020

Hey @Aman9026 can you update your branch with the latest from master? That should resolve the failing checks here. Thanks!

Done

@fluttergithubbot fluttergithubbot merged commit c33d8f4 into flutter:master Sep 8, 2020
@Oklahomawhore
Copy link

Oklahomawhore commented Apr 7, 2021

how to change title for individual pages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web] Page title is set via title property of MaterialApp

6 participants

@Aman9026 @fluttergithubbot @Piinks @Oklahomawhore @goderbauer @googlebot