Add native stacktrace field for PlatformException.#64199
Merged
fluttergithubbot merged 14 commits intoflutter:masterfrom Aug 20, 2020
Merged
Add native stacktrace field for PlatformException.#64199fluttergithubbot merged 14 commits intoflutter:masterfrom
fluttergithubbot merged 14 commits intoflutter:masterfrom
Conversation
added 14 commits
August 20, 2020 10:31
… stacktrace in it from native side.
6c3aaaf to
7586f34
Compare
Contributor
|
Please edit the PR description to add the issue that this PR is fixing. |
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exposing an extra field for native stacktrace from PlatformException. This change would follow by further changes on Flutter Engine to give back native stacktrace information for both iOS&Android. This is essential for crash reporting, currently our client can only see the error message Instance of 'PlatformException' if the crash is coming from native platform.
Related Issues
Fixing the following devicelab test failures regarding the previous PR:
platform_views_scroll_perf_ios__timeline_summary
channels_integration_test_ios
channels_integration_test
channels_integration_test_win
Tests
I added the following tests:
flutter/test/services/message_codecs_test.dart
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.