Skip to content

Add native stacktrace field for PlatformException.#64199

Merged
fluttergithubbot merged 14 commits intoflutter:masterfrom
lidongze91:crash_report
Aug 20, 2020
Merged

Add native stacktrace field for PlatformException.#64199
fluttergithubbot merged 14 commits intoflutter:masterfrom
lidongze91:crash_report

Conversation

@lidongze91
Copy link
Contributor

@lidongze91 lidongze91 commented Aug 19, 2020

Description

Exposing an extra field for native stacktrace from PlatformException. This change would follow by further changes on Flutter Engine to give back native stacktrace information for both iOS&Android. This is essential for crash reporting, currently our client can only see the error message Instance of 'PlatformException' if the crash is coming from native platform.

Related Issues

Fixing the following devicelab test failures regarding the previous PR:
platform_views_scroll_perf_ios__timeline_summary
channels_integration_test_ios
channels_integration_test
channels_integration_test_win

Tests

I added the following tests:

flutter/test/services/message_codecs_test.dart

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 19, 2020
@lidongze91 lidongze91 requested a review from cyanglaz August 20, 2020 00:36
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz
Copy link
Contributor

Please edit the PR description to add the issue that this PR is fixing.

@fluttergithubbot fluttergithubbot merged commit abbd5b1 into flutter:master Aug 20, 2020
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants