Add native stacktrace field for PlatformException#63502
Merged
lidongze91 merged 14 commits intoflutter:masterfrom Aug 13, 2020
Merged
Add native stacktrace field for PlatformException#63502lidongze91 merged 14 commits intoflutter:masterfrom
lidongze91 merged 14 commits intoflutter:masterfrom
Conversation
added 8 commits
August 3, 2020 17:02
added 2 commits
August 11, 2020 10:59
Contributor
Author
|
Not sure why presubmits failed previously though. Is it possibly because of the failing flutter build? |
… stacktrace in it from native side.
jonahwilliams
pushed a commit
that referenced
this pull request
Aug 13, 2020
This reverts commit c67eafa.
jonahwilliams
pushed a commit
that referenced
this pull request
Aug 13, 2020
13 tasks
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
* Add native stacktrace field for PlatformException * Mute the readValue check for stacktrace. * polish * Add unit test and further polish * Added more comments * remove unnecessary import * fill in stacktrace to JSONMethodCodec and fix tests * fix style * Fix format * Remove unnecessary TODO since not all explicitly declared errors have stacktrace in it from native side. * Handle case for exception without stacktrace on jsonMethodCodec * Add more unit tests * format test Co-authored-by: Ben Li <libe@google.com>
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
)" (flutter#63705) This reverts commit c67eafa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exposing an extra field for native stacktrace from PlatformException. This change would follow by further changes on Flutter Engine to give back native stacktrace information for both iOS&Android. This is essential for crash reporting, currently our client can only see the error message
Instance of 'PlatformException'if the crash is coming from native platform.Related Issues
b/158148913
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.