Skip to content

Revert "Add native stacktrace field for PlatformException"#63705

Merged
jonahwilliams merged 1 commit intomasterfrom
revert-63502-crash_report
Aug 13, 2020
Merged

Revert "Add native stacktrace field for PlatformException"#63705
jonahwilliams merged 1 commit intomasterfrom
revert-63502-crash_report

Conversation

@jonahwilliams
Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams commented Aug 13, 2020

Reverts #63502

This breaks the channel integration tests:

08-13 14:02:25.172  2404  2404 E MethodChannel#json-method: Failed to handle method call result
08-13 14:02:25.172  2404  2404 E MethodChannel#json-method: java.lang.IllegalArgumentException: Invalid envelope: ["error",null,null,null]
08-13 14:02:25.172  2404  2404 E MethodChannel#json-method: 	at io.flutter.plugin.common.JSONMethodCodec.decodeEnvelope(JSONMethodCodec.java:91)
08-13 14:02:25.172  2404  2404 E MethodChannel#json-method: 	at io.flutter.plugin.common.MethodChannel$IncomingResultHandler.reply(MethodChannel.java:207)
08-13 14:02:25.172  2404  2404 E MethodChannel#json-method: 	at io.flutter.embedding.engine.dart.DartMessenger.handlePlatformMessageResponse(DartMessenger.java:103)
08-13 14:02:25.172  2404  2404 E MethodChannel#json-method: 	at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessageResponse(FlutterJNI.java:703)
08-13 14:02:25.172  2404  2404 E MethodChannel#json-method: 	at android.os.MessageQueue.nativePollOnce(Native Method)
08-13 14:02:25.172  2404  2404 E MethodChannel#json-method: 	at android.os.MessageQueue.next(MessageQueue.java:336)
08-13 14:02:25.172  2404  2404 E MethodChannel#json-method: 	at android.os.Looper.loop(Looper.java:174)
08-13 14:02:25.172  2404  2404 E MethodChannel#json-method: 	at android.app.ActivityThread.main(ActivityThread.java:7356)
08-13 14:02:25.172  2404  2404 E MethodChannel#json-method: 	at java.lang.reflect.Method.invoke(Native Method)
08-13 14:02:25.172  2404  2404 E MethodChannel#json-method: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
08-13 14:02:25.172  2404  2404 E MethodChannel#json-method: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

@cyanglaz

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 13, 2020
@jonahwilliams jonahwilliams merged commit 9e162cb into master Aug 13, 2020
@jonahwilliams jonahwilliams deleted the revert-63502-crash_report branch August 13, 2020 21:03
@cyanglaz
Copy link
Copy Markdown
Contributor

cyanglaz commented Aug 13, 2020

CC @lidongze91

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@mingwandroid
Revert "Add native stacktrace field for PlatformException (flutter#63502
9f7ac56 
)" (flutter#63705)

This reverts commit c67eafa.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @cyanglaz @googlebot