Make large jumpTo recommend deferred loading#64271
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Aug 21, 2020
Merged
Make large jumpTo recommend deferred loading#64271fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
Contributor
|
It would be nice if we could have a memory test for this. On iOS, we now have a timeline of memory usages that can be used to capture the peak memory usage (flutter/engine#18516). |
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this patch, a fling of a scrollable will end up recommending deferred loading, but not a similarly large (or larger)
jumpTo.This adds an
_impliedVelocityfield toScrollPositionthat tracks how many pixels were forced in a single frame, and adds that to the activity's velocity when asking theScrollPhysicswhether we should defer.Related Issues
Fixes #64124
Tests
I added the following tests:
Test that this works as expected when using jumpTo with large values.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.