[flutter_tools] remove globals from tracing and add unit tests#65490
Merged
jonahwilliams merged 2 commits intoflutter:masterfrom Sep 9, 2020
Merged
[flutter_tools] remove globals from tracing and add unit tests#65490jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams merged 2 commits intoflutter:masterfrom
Conversation
liyuqian
approved these changes
Sep 9, 2020
Contributor
liyuqian
left a comment
There was a problem hiding this comment.
LGTM. Thanks for adding these sample tests! I'll add similar ones to my PR once this is merged :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes global variables and adds unit tests that can be copied for #65118