Add sample code for ScaleTransition#63886
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Piinks
left a comment
There was a problem hiding this comment.
Hey @ChoiAhHyun welcome! 🎉
Thank you for the contribution! Just one small change below.
| /// | ||
| /// @override | ||
| /// Widget build(BuildContext context) { | ||
| /// return ScaleTransition( |
There was a problem hiding this comment.
Can you wrap a Scaffold around the transition?
…ample_code # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
|
@Piinks Hi! I updated my code to reflect your comment :) |
Piinks
left a comment
There was a problem hiding this comment.
LGTM, thank you for the contribution!
|
This pull request is not suitable for automatic merging in its current state.
|
|
Hi @ChoiAhHyun would you update your branch with changes from master once more? That should resolve this check that is stuck. |
…ample_code # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Description
ScaleTransition doesn't have sample code, so I added it. Thank you:)
Reference: https://api.flutter.dev/flutter/widgets/ScaleTransition-class.html
Related Issues
N/A
Tests
N/A
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.