Skip to content

Re-land ScaffoldMessenger#65416

Merged
HansMuller merged 1 commit intoflutter:masterfrom
HansMuller:scaffold_messenger
Sep 8, 2020
Merged

Re-land ScaffoldMessenger#65416
HansMuller merged 1 commit intoflutter:masterfrom
HansMuller:scaffold_messenger

Conversation

@HansMuller
Copy link
Contributor

Fixed a typo in ScaffoldState._unregister() reported by @creativecreatorormaybenot in #65212 which caused failures in flutter_gallery__transition_perf_e2e and flutter_gallery_sksl__transition_perf.

Fixes #65212.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 8, 2020
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@HansMuller HansMuller merged commit adc5f26 into flutter:master Sep 8, 2020
@HansMuller HansMuller deleted the scaffold_messenger branch September 8, 2020 23:02
HansMuller pushed a commit that referenced this pull request Sep 9, 2020
HansMuller added a commit that referenced this pull request Sep 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scaffolds are not removed in Release Mode

3 participants