(insert|move|remove)ChildRenderObject Deprecation: Step 2#64217
Merged
tvolkert merged 1 commit intoflutter:masterfrom Aug 20, 2020
tvolkert:childToSlot
Merged
(insert|move|remove)ChildRenderObject Deprecation: Step 2#64217tvolkert merged 1 commit intoflutter:masterfrom tvolkert:childToSlot
tvolkert merged 1 commit intoflutter:masterfrom
tvolkert:childToSlot
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This follows 21cfed3 by removing the
childToSlotpattern usageswhere possible - namely,
RenderObjectsubclasses. There are stillusages of the pattern in
RenderObjectElementsubclasses, where theyuse the pattern to efficiently forget a child in
forgetChild().Related Issues
#63269
Tests
Test exemption: this just removes code. The existing tests passing validates the change.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].