Skip to content

(insert|move|remove)ChildRenderObject Deprecation: Step 2#64217

Merged
tvolkert merged 1 commit intoflutter:masterfrom
tvolkert:childToSlot
Aug 20, 2020
Merged

(insert|move|remove)ChildRenderObject Deprecation: Step 2#64217
tvolkert merged 1 commit intoflutter:masterfrom
tvolkert:childToSlot

Conversation

@tvolkert
Copy link
Contributor

Description

This follows 21cfed3 by removing the childToSlot pattern usages
where possible - namely, RenderObject subclasses. There are still
usages of the pattern in RenderObjectElement subclasses, where they
use the pattern to efficiently forget a child in forgetChild().

Related Issues

#63269

Tests

Test exemption: this just removes code. The existing tests passing validates the change.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 20, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@tvolkert tvolkert changed the title (insert|move|remove)ChildRenderObject Deprecation: Step 1 (insert|move|remove)ChildRenderObject Deprecation: Step 2 Aug 20, 2020
@tvolkert tvolkert requested a review from goderbauer August 20, 2020 02:08
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert tvolkert merged commit 2d0634e into flutter:master Aug 20, 2020
@tvolkert tvolkert deleted the childToSlot branch August 20, 2020 17:57
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants