Skip to content

Add WindowProc delegation to Windows template#64166

Merged
stuartmorgan-g merged 3 commits intoflutter:masterfrom
stuartmorgan-g:windowproc-delegation-template
Aug 21, 2020
Merged

Add WindowProc delegation to Windows template#64166
stuartmorgan-g merged 3 commits intoflutter:masterfrom
stuartmorgan-g:windowproc-delegation-template

Conversation

@stuartmorgan-g
Copy link
Contributor

Description

This wires up the new WindowProc delegation system that allows plugins
to handle top-level window messages (e.g., to control resize behavior).

Related Issues

Fixes #53168

Tests

I added the following tests: None (Windows e2e tests aren't available yet)

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change.

This wires up the new WindowProc delegation system that allows plugins
to handle top-level window messages (e.g., to control resize behavior).

Fixes flutter#53168
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 19, 2020
@stuartmorgan-g
Copy link
Contributor Author

This will need to wait until there's been an engine roll to land, since it uses new API.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@stuartmorgan-g stuartmorgan-g merged commit ca0ddbb into flutter:master Aug 21, 2020
@stuartmorgan-g stuartmorgan-g deleted the windowproc-delegation-template branch August 21, 2020 00:36
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
This wires up the new WindowProc delegation system that allows plugins
to handle top-level window messages (e.g., to control resize behavior).

Fixes flutter#53168
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
This wires up the new WindowProc delegation system that allows plugins
to handle top-level window messages (e.g., to control resize behavior).

Fixes flutter#53168
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support WindowProc delegation in plugin API

3 participants