Skip to content

Add sample code to RelativePositionedTransition#63940

Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom
ny927:relativePositionedTransitionSample
Sep 8, 2020
Merged

Add sample code to RelativePositionedTransition#63940
fluttergithubbot merged 4 commits intoflutter:masterfrom
ny927:relativePositionedTransitionSample

Conversation

@ny927
Copy link
Contributor

@ny927 ny927 commented Aug 17, 2020

Description

RelativePositionedTransition didn't have sample code, so I added it.
Reference: https://api.flutter.dev/flutter/widgets/RelativePositionedTransition-class.html

Related Issues

N/A

Tests

N/A. Only the doc changed.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 17, 2020
@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 17, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer
Copy link
Member

goderbauer commented Aug 17, 2020

Before we review this in-detail: Can you please fix the error reported by the analyzer: https://github.com/flutter/flutter/pull/63940/checks?check_run_id=993030758

Thanks.

@goderbauer goderbauer requested a review from Piinks August 19, 2020 21:50
@Piinks Piinks added a: animation Animation APIs d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation labels Aug 19, 2020
@ny927
Copy link
Contributor Author

ny927 commented Aug 26, 2020

@goderbauer
I fixed the error. Thank you for checking.

Piinks
Piinks approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ny927! This LGTM, thank you for the contribution! 🎉

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Aug 26, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor

Piinks commented Aug 27, 2020

Hi @ny927 can you update your branch with the latest from master? That should resolve the failing check here.

@ny927
Copy link
Contributor Author

ny927 commented Aug 27, 2020

@Piinks I have updated my branch. Thanks!

@Piinks
Copy link
Contributor

Piinks commented Aug 27, 2020

Thank you so much @ny927, it looks like it will need another update due to #64723
Sorry about that. We really appreciate your work on this!

@ny927
Copy link
Contributor Author

ny927 commented Sep 3, 2020

@Piinks Sorry for late reply. I updated my branch.

@fluttergithubbot fluttergithubbot merged commit c067557 into flutter:master Sep 8, 2020
@ny927 ny927 deleted the relativePositionedTransitionSample branch September 10, 2020 10:47
@lanistor
Copy link

lanistor commented Jul 25, 2021 •
edited
Loading

The sample code is no longer be useful, because as Animation<Rect> will throw error with nullsafe. And no i cannot find a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

a: animation Animation APIs d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ny927 @goderbauer @fluttergithubbot @Piinks @lanistor @googlebot