Skip to content

Clarified '/' route in initialRoute docs#65460

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
NevercodeHQ:initialroute_docs_fix
Sep 9, 2020
Merged

Clarified '/' route in initialRoute docs#65460
fluttergithubbot merged 1 commit intoflutter:masterfrom
NevercodeHQ:initialroute_docs_fix

Conversation

@markusaksli-nc
Copy link
Contributor

Description

This PR clarifies the fact that Navigator will always load the / route as the root of initialRoute deep links and that even simple routes like /a will be treated as deep links (this would mean two routes are pushed). This is to deter new users from trying to use this property when they could just use home or routes: { '/': (context) =>... instead. The resulting confusion can be seen in the linked issue.

Reset and clean PR of #64793 since there were issues with fork master diffs.

Related Issues

Fixes #64775

Tests

Not necessary, this is a documentation PR.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 9, 2020
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit f0f02ac into flutter:master Sep 9, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2021
@TahaTesser TahaTesser deleted the initialroute_docs_fix branch January 28, 2023 23:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MaterialApp onGenerateRoute show unexpected behaviour.

4 participants