Create process types to allow filtering Processes by them by entantoencuanto · Pull Request #8583 · decidim/decidim

entantoencuanto · 2021-12-02T16:58:04Z

🎩 What? Why?

This PR:

Adds a new Decidim::ParticipatoryProcessType model associated with processes
Adds admin management of the model allowing to create, update and destroy participatory process types and assign a process to a type
Adds a filter in processes index and process groups processes list block which appears if there is any process type with processes in the corresponding context of other filters search results and only shows the types with processes in the search results of the other filters.
Changes the assemblies types filter to behave like the participatory process types filter, hiding it if there is no types with assemblies and listing only the types with assemblies

📌 Related Issues

Link your PR to an issue

Related to https://meta.decidim.org/processes/roadmap/f/122/proposals/16850
Fixes #?

Testing

As admin visit the participatory processes section, add some types and assign some processes to them. Go to the front and use the type filter both in global index and groups of processes (remember to enable the participatory processes content block on processes groups landing pages to see the processes and the filter)

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

📷 Screenshots

Please add screenshots of the changes you're proposing

♥️ Thank you!

…ocess

This includes: * Admin controller for CRUD * Admin form * Admin commands for CRUD * New permissions for admins * New admin log presenter * Admin menu item and views

Now the selection is not affected by changes on the other filters, the old behavior was confusing showing available types of the current filter

…ilter

aramollis · 2021-12-30T22:35:48Z

📷 Screenshots

Some screenshots of the changes proposed:

In the processes & groups processes list (frontend view):

Participants and visitors can see a new filter drop-down menu "Process type", which shows only the options in which if there is any assigned process. If there is none, the filter is not displayed.

In the admin management of the process type (backend view):

Admin users can create, update, and destroy participatory process types just as they can with assembly types from /admin/participatory_process_types:

In the admin edit page of each process (backend view):

Admin users can assign a process to a "process type":

entantoencuanto · 2022-01-03T12:42:32Z

Ready to check, @andreslucena

cc/ @decidim/product

andreslucena

Sorry for the delay on reviewing this one @entantoencuanto
I found some typos. Can you check them?
Also, have you took the AssemblyTypes implementation to make this one? Just trying to understand how easy it'd be to implement the generic SpaceTypes in the future if we need it.
Finally, it'd be great to have a second look on this one as it's a big PR, so I'm invoking @ferblape to review this one

.../controllers/decidim/participatory_processes/admin/participatory_process_types_controller.rb

decidim-participatory_processes/config/locales/en.yml

decidim-participatory_processes/lib/decidim/participatory_processes/api.rb

* develop: (134 commits) Remove Rectify::Presenter references (#8758) Clarify the locales on the list of admins (#8838) Fix activity cell disappearing author images (#8826) Fix notifications when there is a note proposal in other spaces than processes (#8822) Fix accountability text search (#8831) Fix displaying hidden meetings in show process page (#8823) Fix docs for install-decidim.sh permissions (#8839) Fix report moderation for all the spaces (#8813) Clarify the comment at the resource search class (#8829) Fix displaying hidden related resources (#8812) Replace Decidim mentions in UI with 'the platform' (#8827) Add natively a .keep file to empty directory to include on git committing (#8830) Fix scope validation on initiative's creation (#8755) Replace `searchlight` with `ransack` which is already a core dependency (#8748) Fix characters not encoded in highlighted participatory process group title (#8820) Test ensuring the moderated comments are not computed in stats (#8816) Update rails to 6.0.4.6 and puma to 5.6.2 (#8817) Fix displaying hidden meetings in processes group's "upcoming meetings" content block (#8818) Fix displaying hidden meetings in homepage's "upcoming meetings" content block (#8809) Improve "Release Candidates" release docs (#8804) ...

…ction

…ipatory_processes/admin/participatory_process_types_controller.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

ferblape · 2022-02-22T06:17:45Z

Sorry I missed your comment @andreslucena, I'll take a look ASAP

ferblape

OK to me! @andreslucena it's easy to check in a local development_app but you can also review it in our staging https://decidim.populate.tools/processes?locale=es

andreslucena

Some tiny changes and we're good to go 😄

CHANGELOG.md

...ses/app/commands/decidim/participatory_processes/admin/destroy_participatory_process_type.rb

...sses/app/commands/decidim/participatory_processes/admin/update_participatory_process_type.rb

...sses/app/commands/decidim/participatory_processes/admin/create_participatory_process_type.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* develop: (57 commits) Add a subtitle to assemblies and processes pages (#8918) Add a subtitle to votings page (#8919) Fix profile notifications (#8943) Fix email for verification conflict with managed users (#8926) Move VAPID keys generators to core (#8923) Fix officialized user event missing translations (#8927) Fix verification report with multitenants: notify it only to admins of that organization (#8929) Fix processes creation form with stats, metrics and announcements (#8925) Fix flaky spec in meetings multi-date selectors (#8924) Local HTML validator for the CI (#8937) Fix translatable presence validator for hyphenated locales (#8795) Fix link to docs in initiatives admin (#8921) Fix initiatives signatures issues (#8448) Fix the meetings export to also include unpublished meetings (#8874) Fix heading order in the consultation question page (#8920) Fix diff mode selector roles and tabindexes (#8912) Fix budget hard dependency and caching flag issues in comments (#8899) Fix emoji picker hiding Foundation Abide form errors (#8886) Fix logical heading order for the endorsers list (#8892) Fix Foundation Abide errors for Rails remote (AJAX) forms (#8889) ...

entantoencuanto changed the title ~~Feature/process types~~ Create process types to allow filtering Processes by them Dec 2, 2021

entantoencuanto force-pushed the feature/process_types branch 5 times, most recently from 4edb57d to d2ab590 Compare December 3, 2021 17:27

entantoencuanto marked this pull request as ready for review December 3, 2021 17:43

entantoencuanto added 23 commits December 3, 2021 18:44

Add migration to create decidim_participatory_process_types table

b48635a

Add ParticipatoryProcessType model and association in ParticipatoryPr…

29d821d

…ocess

Add participatory process types management from admin

5b89a1d

This includes: * Admin controller for CRUD * Admin form * Admin commands for CRUD * New permissions for admins * New admin log presenter * Admin menu item and views

Add association with type from processes admin interface

940a4d1

Include changes in process type to admin log

a10642b

Add type to ParticipatoryProcessSearch service

f203c21

Allow filter also by process type in cells

d2ed481

Add type filter to process_filters cell

85027a3

Include type in default_filter_params methods

7da4738

Add participatory_process_type factory

d497a00

Add process type model tests

e81080e

Fix test

dc4abaa

Add tests for commands and form managing process types

92c8366

Add integration tests for participatory process types admin management

b45b98a

Add participatory process types seeds

a46649d

Add test for process type log presenters

2f54101

Add some integration tests for process types filters

ee85a94

Copy processes filters styles from assemblies

f3ced68

Add loading message in processes grid

f6bb7a9

Update criteria to display groups types in selection

0eebe97

Now the selection is not affected by changes on the other filters, the old behavior was confusing showing available types of the current filter

Hide empty assemblies types in filter

1e6dffa

Hide assemblies types filter when there are no types to display

ad84a0c

Add tests to ensure the type filters are hidden when no available types

6d785a8

Fix the translations to use the same texts as in the assembly types f…

00a8e77

…ilter

andreslucena added type: feature and removed type: enhancement labels Jan 10, 2022

andreslucena requested a review from ferblape February 1, 2022 09:38

andreslucena requested changes Feb 1, 2022

View reviewed changes

entantoencuanto and others added 6 commits February 18, 2022 12:20

Fix process type filter

9aaf702

Fix search result method call name

665138e

Display available assemblies types in filter regardless the type sele…

de5379b

…ction

Update decidim-participatory_processes/app/controllers/decidim/partic…

18945c5

…ipatory_processes/admin/participatory_process_types_controller.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

Update decidim-participatory_processes/config/locales/en.yml

8feca60

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

entantoencuanto force-pushed the feature/process_types branch from 909f6c6 to 8feca60 Compare February 18, 2022 17:27

ferblape previously approved these changes Feb 23, 2022

View reviewed changes

andreslucena requested changes Feb 28, 2022

View reviewed changes

Update CHANGELOG.md

2f246d1

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

entantoencuanto dismissed ferblape’s stale review via 2f246d1 March 2, 2022 12:15

entantoencuanto and others added 4 commits March 2, 2022 13:16

Inherit from Decidim::Command

459aa98

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

Inherit from Decidim::Command

ae7e318

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

Inherit from Decidim::Command

d6b09d9

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

andreslucena approved these changes Mar 2, 2022

View reviewed changes

andreslucena merged commit 6ecd0ff into develop Mar 9, 2022

andreslucena deleted the feature/process_types branch March 9, 2022 14:33

larsUE mentioned this pull request Aug 23, 2022

Partizipationsportal anpassen puzzle/decidim-zuerich#246

Closed

paulinebessoles mentioned this pull request May 17, 2023

Add process type documentation decidim/documentation#128

Closed

RCheesley mentioned this pull request May 20, 2023

WIP: Add process type docs decidim/documentation#130

Closed

alecslupu added this to the 0.27.0 milestone Jul 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Create process types to allow filtering Processes by them#8583

Create process types to allow filtering Processes by them#8583
andreslucena merged 41 commits intodevelopfrom
feature/process_types

entantoencuanto commented Dec 2, 2021 •

edited

Loading

Uh oh!

aramollis commented Dec 30, 2021

Uh oh!

entantoencuanto commented Jan 3, 2022

Uh oh!

andreslucena left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ferblape commented Feb 22, 2022

Uh oh!

ferblape left a comment

Uh oh!

andreslucena left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

entantoencuanto commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

Testing

📋 Checklist

📷 Screenshots

Uh oh!

aramollis commented Dec 30, 2021

📷 Screenshots

In the processes & groups processes list (frontend view):

In the admin management of the process type (backend view):

In the admin edit page of each process (backend view):

Uh oh!

entantoencuanto commented Jan 3, 2022

Uh oh!

andreslucena left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ferblape commented Feb 22, 2022

Uh oh!

ferblape left a comment

Choose a reason for hiding this comment

Uh oh!

andreslucena left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

entantoencuanto commented Dec 2, 2021 •

edited

Loading