Skip to content

Fix budget hard dependency and caching flag issues in comments #8899

Merged
andreslucena merged 1 commit intodecidim:developfrom
i-need-another-coffee:fix/comment-cells
Feb 25, 2022
Merged

Fix budget hard dependency and caching flag issues in comments #8899
andreslucena merged 1 commit intodecidim:developfrom
i-need-another-coffee:fix/comment-cells

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

  • Fixing an edge case error when the Decidim::Budgets is not enabled in the gemfile.
  • Fixing a case when the logged in users cannot report comments as they are accessing logged out version of cache, which does not contain the report form.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

For Budgets issue :

  • Go to Gemfile , replace decidim gem with a list of gems ( like the one here )
  • run bundle install and restart the application
  • Without the patch you should see an error when visiting a resource page with comments
  • Applying the patch, you should be able to see the comments

For Cache issue:

  • Activate cache in the application
  • visit as loggout visitor a page with comments
  • login
  • repeat the visit
  • try to report a comment
  • see the login window
  • Apply the patch
  • retry to report a comment

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@alecslupu alecslupu marked this pull request as draft February 23, 2022 07:54
@alecslupu alecslupu marked this pull request as ready for review February 23, 2022 11:32
@alecslupu alecslupu requested a review from roxanaopr February 23, 2022 11:32
@andreslucena andreslucena added the type: fix PRs that implement a fix for a bug label Feb 24, 2022
@andreslucena andreslucena changed the title Improve comments cells Fix budget hard dependency and caching flag issues in comments Feb 25, 2022
@andreslucena andreslucena merged commit 0ec4c29 into decidim:develop Feb 25, 2022
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

entantoencuanto added a commit that referenced this pull request Mar 2, 2022
* develop: (57 commits)
  Add a subtitle to assemblies and processes pages (#8918)
  Add a subtitle to votings page (#8919)
  Fix profile notifications (#8943)
  Fix email for verification conflict with managed users (#8926)
  Move VAPID keys generators to core (#8923)
  Fix officialized user event missing translations (#8927)
  Fix verification report with multitenants: notify it only to admins of that organization (#8929)
  Fix processes creation form with stats, metrics and announcements (#8925)
  Fix flaky spec in meetings multi-date selectors (#8924)
  Local HTML validator for the CI (#8937)
  Fix translatable presence validator for hyphenated locales (#8795)
  Fix link to docs in initiatives admin (#8921)
  Fix initiatives signatures issues (#8448)
  Fix the meetings export to also include unpublished meetings (#8874)
  Fix heading order in the consultation question page (#8920)
  Fix diff mode selector roles and tabindexes (#8912)
  Fix budget hard dependency and caching flag issues in comments (#8899)
  Fix emoji picker hiding Foundation Abide form errors (#8886)
  Fix logical heading order for the endorsers list (#8892)
  Fix Foundation Abide errors for Rails remote (AJAX) forms (#8889)
  ...
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

No need to do that anymore, I've already done it.

@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
@alecslupu alecslupu deleted the fix/comment-cells branch October 31, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: comments type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants