Fix profile notifications#8943
Merged
andreslucena merged 4 commits intodecidim:developfrom Mar 2, 2022
Merged
Conversation
andreslucena
reviewed
Mar 2, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Awesome! I don't know why, but I thought this was something from how we were generating these associations in the seeds 😄
Just a small doubt, I see that we're still leaving this in following:
Should we drop it there too?
Contributor
Author
Yeah. Those classes (without 'hide' class) aren't breaking anything, but they are just useless. |
Member
|
Can you please backport to v0.26-stable 🙏🏽? Thanks |
entantoencuanto
added a commit
that referenced
this pull request
Mar 2, 2022
* develop: (57 commits) Add a subtitle to assemblies and processes pages (#8918) Add a subtitle to votings page (#8919) Fix profile notifications (#8943) Fix email for verification conflict with managed users (#8926) Move VAPID keys generators to core (#8923) Fix officialized user event missing translations (#8927) Fix verification report with multitenants: notify it only to admins of that organization (#8929) Fix processes creation form with stats, metrics and announcements (#8925) Fix flaky spec in meetings multi-date selectors (#8924) Local HTML validator for the CI (#8937) Fix translatable presence validator for hyphenated locales (#8795) Fix link to docs in initiatives admin (#8921) Fix initiatives signatures issues (#8448) Fix the meetings export to also include unpublished meetings (#8874) Fix heading order in the consultation question page (#8920) Fix diff mode selector roles and tabindexes (#8912) Fix budget hard dependency and caching flag issues in comments (#8899) Fix emoji picker hiding Foundation Abide form errors (#8886) Fix logical heading order for the endorsers list (#8892) Fix Foundation Abide errors for Rails remote (AJAX) forms (#8889) ...
lahdeero
pushed a commit
to mainio/decidim
that referenced
this pull request
Mar 2, 2022
lahdeero
pushed a commit
to mainio/decidim
that referenced
this pull request
Mar 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When viewing user group members, page shows "This group doesn't have any members yet." even it has members. This happens because notifications.js removed 'hide' class.
Fixes also similar issues with followers and user's own groups page (see screenshots below)
📌 Related Issues
#1784
Testing
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots