Skip to content

Fix the meetings export to also include unpublished meetings#8874

Merged
andreslucena merged 2 commits intodevelopfrom
fix/meetings-export-not-include-unpublished-meetings-8729
Feb 25, 2022
Merged

Fix the meetings export to also include unpublished meetings#8874
andreslucena merged 2 commits intodevelopfrom
fix/meetings-export-not-include-unpublished-meetings-8729

Conversation

@ferblape
Copy link
Copy Markdown
Contributor

🎩 What? Why?

This PR:

  • includes all meetings in the export (not just the published ones)
  • adds a column to the export named published indicating if the meeting is published or not

📌 Related Issues

Testing

As an admin:

  • go to a participatory space meetings
  • unpublish some meetings
  • ask for an export
  • check all meetings have been included, not just the published ones

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Screenshot of the new column in a exported file (CSV):

Screenshot 2022-02-22 at 06 54 47

♥️ Thank you!

@andreslucena andreslucena changed the title Meetings export includes all meetings Fix the meetings export to also include unpublished meetings Feb 22, 2022
@andreslucena andreslucena added project: online-meetings Barcelona City Council contract module: meetings type: fix PRs that implement a fix for a bug labels Feb 22, 2022
@andreslucena andreslucena merged commit 9e01a86 into develop Feb 25, 2022
@andreslucena andreslucena deleted the fix/meetings-export-not-include-unpublished-meetings-8729 branch February 25, 2022 15:16
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@ferblape
Copy link
Copy Markdown
Contributor Author

Yep

entantoencuanto added a commit that referenced this pull request Mar 2, 2022
* develop: (57 commits)
  Add a subtitle to assemblies and processes pages (#8918)
  Add a subtitle to votings page (#8919)
  Fix profile notifications (#8943)
  Fix email for verification conflict with managed users (#8926)
  Move VAPID keys generators to core (#8923)
  Fix officialized user event missing translations (#8927)
  Fix verification report with multitenants: notify it only to admins of that organization (#8929)
  Fix processes creation form with stats, metrics and announcements (#8925)
  Fix flaky spec in meetings multi-date selectors (#8924)
  Local HTML validator for the CI (#8937)
  Fix translatable presence validator for hyphenated locales (#8795)
  Fix link to docs in initiatives admin (#8921)
  Fix initiatives signatures issues (#8448)
  Fix the meetings export to also include unpublished meetings (#8874)
  Fix heading order in the consultation question page (#8920)
  Fix diff mode selector roles and tabindexes (#8912)
  Fix budget hard dependency and caching flag issues in comments (#8899)
  Fix emoji picker hiding Foundation Abide form errors (#8886)
  Fix logical heading order for the endorsers list (#8892)
  Fix Foundation Abide errors for Rails remote (AJAX) forms (#8889)
  ...
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: meetings project: online-meetings Barcelona City Council contract type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meetings export does not show unpublished meetings

3 participants