Skip to content

Local HTML validator for the CI#8937

Merged
andreslucena merged 4 commits intodecidim:developfrom
mainio:test/local-html-validator
Mar 1, 2022
Merged

Local HTML validator for the CI#8937
andreslucena merged 4 commits intodecidim:developfrom
mainio:test/local-html-validator

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Feb 28, 2022

🎩 What? Why?

The official W3C HTML Nu Validator has been offline today (2022-02-28). This causes the HTML validation tests to fail.

This PR adds a local validator service through the official Docker container and configures it to be used in the CI pipelines.

Testing

See whether the CI is green.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@ahukkanen ahukkanen marked this pull request as draft February 28, 2022 17:32
@ahukkanen ahukkanen marked this pull request as ready for review February 28, 2022 18:42
@ahukkanen
Copy link
Copy Markdown
Contributor Author

The validator service was added to these pipelines with current HTML validation tests:

  • decidim-core - [CI] Core (system specs)
  • decidim-debates - [CI] Debates
  • decidim-initiatives - CI] Initiatives (system public)
  • decidim-meetings - [CI] Meetings (system public)
  • decidim-pages - [CI] Pages
  • decidim-participatory_processes - [CI] Participatory processes
  • decidim-proposals - [CI] Proposals (system public)

The validator service was added to these pipelines for future needs (no current HTML validation tests):

  • decidim-accountability - [CI] Accountability
  • decidim-admin - [CI] Admin (system tests)
  • decidim-assemblies - [CI] Assemblies
  • decidim-blogs - [CI] Blogs
  • decidim-budgets - [CI] Budgets
  • decidim-comments - [CI] Comments
  • decidim-conferences - [CI] Conferences
  • decidim-consultations - [CI] Consultations
  • decidim-elections - [CI] Elections (system admin)
  • decidim-elections - [CI] Elections (system public)
  • decidim-initiatives - [CI] Initiatives (system admin)
  • decidim-meetings - [CI] Meetings (system admin)
  • decidim-proposals - [CI] Proposals (system admin)
  • decidim-sortitions - [CI] Sortitions
  • decidim-surveys - [CI] Surveys
  • decidim-system - [CI] System
  • decidim-templates - [CI] Templates
  • decidim-verifications - [CI] Verifications

The validator service was not added to these pipelines (probably not needed now or in the future):

  • decidim-api - [CI] Api
  • decidim-dev - [CI] Dev (system specs)
  • decidim-forms - [CI] Forms
  • decidim-generators - [CI] Generators

@andreslucena andreslucena added the type: internal PRs that aren't necessary to add to the CHANGELOG for implementers label Mar 1, 2022
@andreslucena andreslucena merged commit fe76745 into decidim:develop Mar 1, 2022
@ahukkanen ahukkanen deleted the test/local-html-validator branch March 1, 2022 08:43
entantoencuanto added a commit that referenced this pull request Mar 2, 2022
* develop: (57 commits)
  Add a subtitle to assemblies and processes pages (#8918)
  Add a subtitle to votings page (#8919)
  Fix profile notifications (#8943)
  Fix email for verification conflict with managed users (#8926)
  Move VAPID keys generators to core (#8923)
  Fix officialized user event missing translations (#8927)
  Fix verification report with multitenants: notify it only to admins of that organization (#8929)
  Fix processes creation form with stats, metrics and announcements (#8925)
  Fix flaky spec in meetings multi-date selectors (#8924)
  Local HTML validator for the CI (#8937)
  Fix translatable presence validator for hyphenated locales (#8795)
  Fix link to docs in initiatives admin (#8921)
  Fix initiatives signatures issues (#8448)
  Fix the meetings export to also include unpublished meetings (#8874)
  Fix heading order in the consultation question page (#8920)
  Fix diff mode selector roles and tabindexes (#8912)
  Fix budget hard dependency and caching flag issues in comments (#8899)
  Fix emoji picker hiding Foundation Abide form errors (#8886)
  Fix logical heading order for the endorsers list (#8892)
  Fix Foundation Abide errors for Rails remote (AJAX) forms (#8889)
  ...
ahukkanen added a commit to mainio/decidim that referenced this pull request Mar 11, 2022
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants