Skip to content

Move VAPID keys generators to core#8923

Merged
andreslucena merged 2 commits intodevelopfrom
fix/move_vapid_generator
Mar 1, 2022
Merged

Move VAPID keys generators to core#8923
andreslucena merged 2 commits intodevelopfrom
fix/move_vapid_generator

Conversation

@quinHD
Copy link
Copy Markdown
Contributor

@quinHD quinHD commented Feb 25, 2022 •
edited
Loading

🎩 What? Why?

This PR moves the vapid generator task from decidim-dev to decidim-core. To make it available in the builded app.

📌 Related Issues

#8488
more accurate: This comment

Testing

Given that I'm a Decidim implementer,
When I run rails decidim:generate in the root path
Then I have the following ouput:

 VAPID keys correctly generated.
 ************************
 VAPID private key is XXXXXXXXXXXXXX
 VAPID public key is XXXXXXXXXXXXXX

Step by step
In the root folder, run the decidim:pwa:generate_vapid_keys rake task. Copy the the keys and add them to the env variables using the names specified above.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@quinHD quinHD self-assigned this Feb 25, 2022
@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Feb 28, 2022

Two failings specs, both of them flakies:

  1. Meetings: already fixed at Fix flaky spec in meetings multi-date selectors #8924
  2. Core: it's about the ./spec/controllers/manifests_spec.rb, introduced in this same contract. Can you give it a look @quinHD 🙏🏽 ?

ferblape
ferblape previously approved these changes Mar 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ferblape ferblape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quinHD could you complete the PR description?

andreslucena
andreslucena requested changes Mar 1, 2022
View reviewed changes
@quinHD quinHD linked an issue Mar 1, 2022 that may be closed by this pull request
Server setup for Push Notifications #8488
Closed
3 tasks
@andreslucena andreslucena changed the title Move vapid keys generators to core Move VAPID keys generators to core Mar 1, 2022
@andreslucena andreslucena merged commit 3c7ee4f into develop Mar 1, 2022
@andreslucena andreslucena deleted the fix/move_vapid_generator branch March 1, 2022 12:42
entantoencuanto added a commit that referenced this pull request Mar 2, 2022
@entantoencuanto
Merge branch 'develop' into feature/process_types
f78e953 
* develop: (57 commits)
  Add a subtitle to assemblies and processes pages (#8918)
  Add a subtitle to votings page (#8919)
  Fix profile notifications (#8943)
  Fix email for verification conflict with managed users (#8926)
  Move VAPID keys generators to core (#8923)
  Fix officialized user event missing translations (#8927)
  Fix verification report with multitenants: notify it only to admins of that organization (#8929)
  Fix processes creation form with stats, metrics and announcements (#8925)
  Fix flaky spec in meetings multi-date selectors (#8924)
  Local HTML validator for the CI (#8937)
  Fix translatable presence validator for hyphenated locales (#8795)
  Fix link to docs in initiatives admin (#8921)
  Fix initiatives signatures issues (#8448)
  Fix the meetings export to also include unpublished meetings (#8874)
  Fix heading order in the consultation question page (#8920)
  Fix diff mode selector roles and tabindexes (#8912)
  Fix budget hard dependency and caching flag issues in comments (#8899)
  Fix emoji picker hiding Foundation Abide form errors (#8886)
  Fix logical heading order for the endorsers list (#8892)
  Fix Foundation Abide errors for Rails remote (AJAX) forms (#8889)
  ...
@ahukkanen ahukkanen mentioned this pull request Mar 3, 2022
Closed
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

+1 more reviewer

@ferblape ferblape ferblape left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@quinHD quinHD

Labels

module: core project: PWA Barcelona City Council contract target: developer-experience

Projects

None yet

Milestone

0.27.0

Development

Successfully merging this pull request may close these issues.

Server setup for Push Notifications

4 participants

@quinHD @andreslucena @ferblape @alecslupu