Skip to content

Fix flaky spec in meetings multi-date selectors#8924

Merged
andreslucena merged 2 commits intodevelopfrom
test/fix-flaky-meetings-dates
Mar 1, 2022
Merged

Fix flaky spec in meetings multi-date selectors#8924
andreslucena merged 2 commits intodevelopfrom
test/fix-flaky-meetings-dates

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

There was a flaky spec in meetings with multiple dates. This PR fixes that.

https://github.com/decidim/decidim/runs/5340566116?check_suite_focus=true

📌 Related Issues

Link your PR to an issue

Additional context

> 
> Failures:
> 
>   1) Meeting when the meeting is the same as the current year doesn't show the year
>      Failure/Error:
>        within ".extra__date" do
>          expect(page).to have_no_content(meeting.start_time.year)
>        end
> 
>      Capybara::Ambiguous:
>        Ambiguous match, found 2 elements matching visible css ".extra__date"
> 
>      [Image screenshot]: file:///home/runner/work/decidim/decidim/spec/decidim_dummy_app/tmp/screenshots/failures_r_spec_example_groups_meeting_when_the_meeting_is_the_same_as_the_current_year_doesn_t_show_the_year_457.png
> 
>             [Page HTML]: file:///home/runner/work/decidim/decidim/spec/decidim_dummy_app/tmp/screenshots/failures_r_spec_example_groups_meeting_when_the_meeting_is_the_same_as_the_current_year_doesn_t_show_the_year_457.html
> 
> 
>      # ./spec/system/meeting_spec.rb:130:in `block (3 levels) in <top (required)>'
> 
>   2) Meeting when the meeting is different from the current year shows the year
>      Failure/Error:
>        within ".extra__date" do
>          expect(page).to have_content(meeting.start_time.year)
>        end
> 
>      Capybara::Ambiguous:
>        Ambiguous match, found 2 elements matching visible css ".extra__date"
> 
>      [Image screenshot]: file:///home/runner/work/decidim/decidim/spec/decidim_dummy_app/tmp/screenshots/failures_r_spec_example_groups_meeting_when_the_meeting_is_different_from_the_current_year_shows_the_year_90.png
> 
>             [Page HTML]: file:///home/runner/work/decidim/decidim/spec/decidim_dummy_app/tmp/screenshots/failures_r_spec_example_groups_meeting_when_the_meeting_is_different_from_the_current_year_shows_the_year_90.html
> 
> 
>      # ./spec/system/meeting_spec.rb:142:in `block (3 levels) in <top (required)>'
> 
> Finished in 20 minutes 14 seconds (files took 6.83 seconds to load)
> 276 examples, 2 failures
> 
> Failed examples:
> 
> rspec ./spec/system/meeting_spec.rb:127 # Meeting when the meeting is the same as the current year doesn't show the year
> rspec ./spec/system/meeting_spec.rb:139 # Meeting when the meeting is different from the current year shows the year
> 
> Randomized with seed 3755
> 
> Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
> Coverage report generated for (1/2) to /home/runner/work/decidim/decidim/coverage/coverage.xml
> Coverage report generated for (1/2), (2/2) to /home/runner/work/decidim/decidim/coverage/coverage.xml
> Tests Failed
> 

♥️ Thank you!

@andreslucena andreslucena added flaky spec module: meetings type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Mar 1, 2022
@andreslucena andreslucena merged commit af891fb into develop Mar 1, 2022
@andreslucena andreslucena deleted the test/fix-flaky-meetings-dates branch March 1, 2022 10:09
entantoencuanto added a commit that referenced this pull request Mar 2, 2022
* develop: (57 commits)
  Add a subtitle to assemblies and processes pages (#8918)
  Add a subtitle to votings page (#8919)
  Fix profile notifications (#8943)
  Fix email for verification conflict with managed users (#8926)
  Move VAPID keys generators to core (#8923)
  Fix officialized user event missing translations (#8927)
  Fix verification report with multitenants: notify it only to admins of that organization (#8929)
  Fix processes creation form with stats, metrics and announcements (#8925)
  Fix flaky spec in meetings multi-date selectors (#8924)
  Local HTML validator for the CI (#8937)
  Fix translatable presence validator for hyphenated locales (#8795)
  Fix link to docs in initiatives admin (#8921)
  Fix initiatives signatures issues (#8448)
  Fix the meetings export to also include unpublished meetings (#8874)
  Fix heading order in the consultation question page (#8920)
  Fix diff mode selector roles and tabindexes (#8912)
  Fix budget hard dependency and caching flag issues in comments (#8899)
  Fix emoji picker hiding Foundation Abide form errors (#8886)
  Fix logical heading order for the endorsers list (#8892)
  Fix Foundation Abide errors for Rails remote (AJAX) forms (#8889)
  ...
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky spec module: meetings type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants