Skip to content

Fix officialized user event missing translations#8927

Merged
andreslucena merged 3 commits intodecidim:developfrom
CodiTramuntana:fix/add_officialized_user_error_event_missing_translations
Mar 1, 2022
Merged

Fix officialized user event missing translations#8927
andreslucena merged 3 commits intodecidim:developfrom
CodiTramuntana:fix/add_officialized_user_error_event_missing_translations

Conversation

@tramuntanal
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal commented Feb 28, 2022

🎩 What? Why?

This PR fixes the missing translation keys for the officialization notification.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

  • As an admin officialize a participant
  • Check the email sent to admins (in local envs make sure you have a jobs backend running in order to receive the email)

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@tramuntanal tramuntanal changed the title Fix/add officialized user error event missing translations Fix officialized user error event missing translations Feb 28, 2022
@andreslucena andreslucena added module: core type: fix PRs that implement a fix for a bug labels Mar 1, 2022
@andreslucena andreslucena changed the title Fix officialized user error event missing translations Fix officialized user event missing translations Mar 1, 2022
@andreslucena
Copy link
Copy Markdown
Member

I've changed the PR description, as in this case it'll fix #8661. If I've messed it out (again) let me know!

@andreslucena andreslucena merged commit 57cd489 into decidim:develop Mar 1, 2022
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@tramuntanal tramuntanal deleted the fix/add_officialized_user_error_event_missing_translations branch March 1, 2022 13:56
tramuntanal added a commit to CodiTramuntana/decidim that referenced this pull request Mar 1, 2022
entantoencuanto added a commit that referenced this pull request Mar 2, 2022
* develop: (57 commits)
  Add a subtitle to assemblies and processes pages (#8918)
  Add a subtitle to votings page (#8919)
  Fix profile notifications (#8943)
  Fix email for verification conflict with managed users (#8926)
  Move VAPID keys generators to core (#8923)
  Fix officialized user event missing translations (#8927)
  Fix verification report with multitenants: notify it only to admins of that organization (#8929)
  Fix processes creation form with stats, metrics and announcements (#8925)
  Fix flaky spec in meetings multi-date selectors (#8924)
  Local HTML validator for the CI (#8937)
  Fix translatable presence validator for hyphenated locales (#8795)
  Fix link to docs in initiatives admin (#8921)
  Fix initiatives signatures issues (#8448)
  Fix the meetings export to also include unpublished meetings (#8874)
  Fix heading order in the consultation question page (#8920)
  Fix diff mode selector roles and tabindexes (#8912)
  Fix budget hard dependency and caching flag issues in comments (#8899)
  Fix emoji picker hiding Foundation Abide form errors (#8886)
  Fix logical heading order for the endorsers list (#8892)
  Fix Foundation Abide errors for Rails remote (AJAX) forms (#8889)
  ...
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing translation key - officialization

3 participants