Skip to content

Fix verification report with multitenants: notify it only to admins of that organization#8929

Merged
andreslucena merged 1 commit intodecidim:developfrom
CodiTramuntana:fix/report_sent_across_multitenants
Mar 1, 2022
Merged

Fix verification report with multitenants: notify it only to admins of that organization#8929
andreslucena merged 1 commit intodecidim:developfrom
CodiTramuntana:fix/report_sent_across_multitenants

Conversation

@laurajaime
Copy link
Copy Markdown
Contributor

@laurajaime laurajaime commented Feb 28, 2022

🎩 What? Why?

Related to issue #8807.

The managed_user_error_event notifies all admins in all organizations instead of filtering by organization.

[Ajuntament de Sant Just Desvern] <http://participa311-santjust.diba.cat/>

Hola Suport Participa311 Diba,

translation missing: ca.decidim.events.verifications.verify_with_managed_user.email_intro

Xxxx Xxxx<http://participa311-manlleu.diba.cat/profiles/xxxxxx>

translation missing: ca.decidim.events.verifications.verify_with_managed_user.email_outro

Ajuntament de Sant Just Desvern<http://participa311-santjust.diba.cat/>

📌 Related Issues

Testing

  1. Sign in as an admin on an instance with multiple organizations and enable document number authorization
  2. As an admin, represent a new user with a certain document number
  3. As a user, try to get authorized with the same authorization handler and document number
  4. As an admin from another organization, see that you receive the event in your emails

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@andreslucena andreslucena changed the title Fix events in multitenant: notify only organization admins Fix verification report with multitenants: notify only that organization admins Mar 1, 2022
@andreslucena andreslucena changed the title Fix verification report with multitenants: notify only that organization admins Fix verification report with multitenants: notify it only to admins of that organization Mar 1, 2022
@andreslucena andreslucena merged commit c475070 into decidim:develop Mar 1, 2022
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@laurajaime
Copy link
Copy Markdown
Contributor Author

Can you please backport to v0.26-stable 🙏🏽? Thanks

Done!

@tramuntanal tramuntanal deleted the fix/report_sent_across_multitenants branch March 1, 2022 13:53
entantoencuanto added a commit that referenced this pull request Mar 2, 2022
* develop: (57 commits)
  Add a subtitle to assemblies and processes pages (#8918)
  Add a subtitle to votings page (#8919)
  Fix profile notifications (#8943)
  Fix email for verification conflict with managed users (#8926)
  Move VAPID keys generators to core (#8923)
  Fix officialized user event missing translations (#8927)
  Fix verification report with multitenants: notify it only to admins of that organization (#8929)
  Fix processes creation form with stats, metrics and announcements (#8925)
  Fix flaky spec in meetings multi-date selectors (#8924)
  Local HTML validator for the CI (#8937)
  Fix translatable presence validator for hyphenated locales (#8795)
  Fix link to docs in initiatives admin (#8921)
  Fix initiatives signatures issues (#8448)
  Fix the meetings export to also include unpublished meetings (#8874)
  Fix heading order in the consultation question page (#8920)
  Fix diff mode selector roles and tabindexes (#8912)
  Fix budget hard dependency and caching flag issues in comments (#8899)
  Fix emoji picker hiding Foundation Abide form errors (#8886)
  Fix logical heading order for the endorsers list (#8892)
  Fix Foundation Abide errors for Rails remote (AJAX) forms (#8889)
  ...
takahashim added a commit to codeforjapan/decidim-cfj that referenced this pull request Apr 13, 2022
takahashim added a commit to codeforjapan/decidim-cfj that referenced this pull request Apr 13, 2022
takahashim added a commit to codeforjapan/decidim-cfj that referenced this pull request Apr 13, 2022
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verification report event is sent accross multitenant organizations

3 participants