Fix multiple notifications related to managed user events#8888
Closed
tramuntanal wants to merge 5 commits intodecidim:developfrom
Closed
Fix multiple notifications related to managed user events#8888tramuntanal wants to merge 5 commits intodecidim:developfrom
tramuntanal wants to merge 5 commits intodecidim:developfrom
Conversation
d83d05f to
7af2fc2
Compare
laurajaime
approved these changes
Feb 24, 2022
andreslucena
approved these changes
Feb 25, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Awesome, three in one, I appreciate it!
Can you separate the commits in different PRs, though? I prefer it that way, as we're squashing the commits and also using the PR titles in the CHANGELOG generation on release. If you don't have time, let me know, and I can handle it (respecting your authorship of course)
12 tasks
12 tasks
Merged
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR fixes a group of bugs related with the admin notifications related with managed users.
Verification conflict email
Related to issue #8392.
When an admin is notified via email that a participant tried to verify with the data of an already verified managed user the email shows no contents because translations are missing (see screenshot).
Verification report event is sent accross multitenant organizations
Related to issue #8807.
The
managed_user_error_eventnotifies all admins in all organizations instead of filtering by organization.Missing translation keys for officialization notification
Related to issue #8661.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Verification conflict untranslated email
