Skip to content

Fix multiple notifications related to managed user events#8888

Closed
tramuntanal wants to merge 5 commits intodecidim:developfrom
CodiTramuntana:fix/managed_user_error_event_email
Closed

Fix multiple notifications related to managed user events#8888
tramuntanal wants to merge 5 commits intodecidim:developfrom
CodiTramuntana:fix/managed_user_error_event_email

Conversation

@tramuntanal
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal commented Feb 22, 2022

🎩 What? Why?

This PR fixes a group of bugs related with the admin notifications related with managed users.

Verification conflict email
Related to issue #8392.
When an admin is notified via email that a participant tried to verify with the data of an already verified managed user the email shows no contents because translations are missing (see screenshot).

Verification report event is sent accross multitenant organizations
Related to issue #8807.
The managed_user_error_event notifies all admins in all organizations instead of filtering by organization.

[Ajuntament de Sant Just Desvern] <http://participa311-santjust.diba.cat/>

Hola Suport Participa311 Diba,

translation missing: ca.decidim.events.verifications.verify_with_managed_user.email_intro

Xxxx Xxxx<http://participa311-manlleu.diba.cat/profiles/xxxxxx>

translation missing: ca.decidim.events.verifications.verify_with_managed_user.email_outro

Ajuntament de Sant Just Desvern<http://participa311-santjust.diba.cat/>

Missing translation keys for officialization notification
Related to issue #8661.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Verification conflict untranslated email
imatge

♥️ Thank you!

@tramuntanal tramuntanal changed the title Add managed user error event missing translations Fix multiple notifications related to managed user events Feb 22, 2022
laurajaime
laurajaime previously approved these changes Feb 22, 2022
Copy link
Copy Markdown
Contributor

@laurajaime laurajaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, three in one, I appreciate it!
Can you separate the commits in different PRs, though? I prefer it that way, as we're squashing the commits and also using the PR titles in the CHANGELOG generation on release. If you don't have time, let me know, and I can handle it (respecting your authorship of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verification report event is sent accross multitenant organizations Missing translation key - officialization Missing translations

3 participants