Add a subtitle to votings page#8919
Merged
andreslucena merged 4 commits intodecidim:developfrom Mar 2, 2022
Merged
Conversation
Contributor
Author
|
FYI: I applied the same change here as was requested by @carolromero at #8918 (comment). So the added H2 element is only displayed for screen readers now. |
andreslucena
approved these changes
Mar 2, 2022
entantoencuanto
added a commit
that referenced
this pull request
Mar 2, 2022
* develop: (57 commits) Add a subtitle to assemblies and processes pages (#8918) Add a subtitle to votings page (#8919) Fix profile notifications (#8943) Fix email for verification conflict with managed users (#8926) Move VAPID keys generators to core (#8923) Fix officialized user event missing translations (#8927) Fix verification report with multitenants: notify it only to admins of that organization (#8929) Fix processes creation form with stats, metrics and announcements (#8925) Fix flaky spec in meetings multi-date selectors (#8924) Local HTML validator for the CI (#8937) Fix translatable presence validator for hyphenated locales (#8795) Fix link to docs in initiatives admin (#8921) Fix initiatives signatures issues (#8448) Fix the meetings export to also include unpublished meetings (#8874) Fix heading order in the consultation question page (#8920) Fix diff mode selector roles and tabindexes (#8912) Fix budget hard dependency and caching flag issues in comments (#8899) Fix emoji picker hiding Foundation Abide form errors (#8886) Fix logical heading order for the endorsers list (#8892) Fix Foundation Abide errors for Rails remote (AJAX) forms (#8889) ...
ahukkanen
added a commit
to mainio/decidim
that referenced
this pull request
Mar 2, 2022
12 tasks
Contributor
Author
|
Backport at #8950. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
After the heading order related changes, the votings page heading order is also broken. There are few structural issues here as well as the same issue as presented in PR #8918.
This fixes the heading order in the votings space pages as well as implements the same change to the votings space as #8918 implemented for processes and assemblies.
📌 Related Issues
<p>to fix heading order issues #8901 (and the rest of the related changes)Testing
📋 Checklist
docs/.📷 Screenshots
This will introduce a new element on the voting landing page as shown in the screenshot below: