Add a subtitle to assemblies and processes pages#8918
Merged
andreslucena merged 3 commits intodecidim:developfrom Mar 2, 2022
Merged
Add a subtitle to assemblies and processes pages#8918andreslucena merged 3 commits intodecidim:developfrom
andreslucena merged 3 commits intodecidim:developfrom
Conversation
12 tasks
Member
|
Hi @ahukkanen, would it be possible to add to this subtitle some attribute like 'hidden' or 'display:none' so that it is recognized by a screen reader but not visible? I understand the semantic need, but it would be better to avoid more visual elements in the interface that also add very little value. So my question is if there is something that does the opposite of this: https://a11y-101.com/development/aria-hidden |
Contributor
Author
|
@carolromero Done. Generally I don't like the hidden titles as it can be confusing where these headings are displayed if they need to be translated. These accessibility violations are usually trying to tell you something. 😉 |
andreslucena
approved these changes
Mar 2, 2022
entantoencuanto
added a commit
that referenced
this pull request
Mar 2, 2022
* develop: (57 commits) Add a subtitle to assemblies and processes pages (#8918) Add a subtitle to votings page (#8919) Fix profile notifications (#8943) Fix email for verification conflict with managed users (#8926) Move VAPID keys generators to core (#8923) Fix officialized user event missing translations (#8927) Fix verification report with multitenants: notify it only to admins of that organization (#8929) Fix processes creation form with stats, metrics and announcements (#8925) Fix flaky spec in meetings multi-date selectors (#8924) Local HTML validator for the CI (#8937) Fix translatable presence validator for hyphenated locales (#8795) Fix link to docs in initiatives admin (#8921) Fix initiatives signatures issues (#8448) Fix the meetings export to also include unpublished meetings (#8874) Fix heading order in the consultation question page (#8920) Fix diff mode selector roles and tabindexes (#8912) Fix budget hard dependency and caching flag issues in comments (#8899) Fix emoji picker hiding Foundation Abide form errors (#8886) Fix logical heading order for the endorsers list (#8892) Fix Foundation Abide errors for Rails remote (AJAX) forms (#8889) ...
ahukkanen
added a commit
to mainio/decidim
that referenced
this pull request
Mar 2, 2022
12 tasks
Contributor
Author
|
Backport at #8950. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
After the heading level standardization, the heading order is now broken on the participatory space main page for processes and assemblies. The problem is with the "sections" on that main page, such as "related documents", "related images", etc.
I suggest that we add a subtitle to these pages as shown in the screenshots to fix this problem.
We could also change the heading order of the elements on the participatory space main page but the problem with that is that these same elements, such as "related documents" and "related images" are used also e.g. on the proposal pages where the current
<h3>order is correct. Therefore, we would need to create extra logic in these templates to decide which is the correct heading order in which context which would add unnecessary logic in the templates.I know that this is not a simple "fix" per se, as it adds a new element to these pages, but I'm not sure what would be the correct way to solve this issue otherwise as explained above.
📌 Related Issues
<p>to fix heading order issues #8901 (and the rest of the related changes)Testing
📋 Checklist
docs/.📷 Screenshots
Here is the error that is currently shown on the process page for instance:
I suggest that we add these subtitles to fix the problem with the heading order: