Skip to content

Change the participatory space header's subtitle element to a <p> to fix heading order issues#8901

Merged
andreslucena merged 3 commits intodecidim:developfrom
mainio:fix/participatory-space-subtitle-heading
Feb 25, 2022
Merged

Change the participatory space header's subtitle element to a <p> to fix heading order issues#8901
andreslucena merged 3 commits intodecidim:developfrom
mainio:fix/participatory-space-subtitle-heading

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Feb 23, 2022

🎩 What? Why?

This changes the <h2> element in the participatory space subtitles to a <p> element as discussed at:
#8893 (comment)

This makes it easier to control the heading orders below <h1> and also makes it possible to fix some inconsistencies currently with the heading ordering, e.g. that the debate titles are <h2> but proposal titles are <h3>.

The change is related to the rest of the accessibility fixes.

WCAG 2.2 / 1.3.1 Info and Relationships (Level A)

https://www.w3.org/TR/WCAG22/#info-and-relationships
https://www.w3.org/WAI/WCAG22/Understanding/info-and-relationships.html

📌 Related Issues

Testing

Take a look at the subtitle element with the inspector in different participatory spaces and see that it is now a <p>.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

The design is not affected by this change so the before and after looks the same:

Participatory space subtitle

@ahukkanen
Copy link
Copy Markdown
Contributor Author

#8906 fixes the broken test at the participatory processes component.

#8902 and #8877 fix the broken tests in the proposals component.

I'll mark this as a draft before we get those PRs merged.

@ahukkanen ahukkanen marked this pull request as draft February 23, 2022 14:55
@ahukkanen ahukkanen marked this pull request as ready for review February 24, 2022 17:10
@ahukkanen
Copy link
Copy Markdown
Contributor Author

@andreslucena Thanks for merging the related PRs!

I just synced this with develop which means CI is green and this is also ready for review.

@andreslucena andreslucena merged commit c757469 into decidim:develop Feb 25, 2022
@ahukkanen ahukkanen deleted the fix/participatory-space-subtitle-heading branch February 25, 2022 08:08
ahukkanen added a commit to mainio/decidim that referenced this pull request Mar 2, 2022
@ahukkanen
Copy link
Copy Markdown
Contributor Author

Backport at #8950.

@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants