Change the participatory space header's subtitle element to a <p> to fix heading order issues#8901
Merged
andreslucena merged 3 commits intodecidim:developfrom Feb 25, 2022
Conversation
This was referenced Feb 23, 2022
Contributor
Author
Contributor
Author
|
@andreslucena Thanks for merging the related PRs! I just synced this with |
andreslucena
approved these changes
Feb 25, 2022
This was referenced Feb 25, 2022
ahukkanen
added a commit
to mainio/decidim
that referenced
this pull request
Mar 2, 2022
…o fix heading order issues (decidim#8901)
12 tasks
Contributor
Author
|
Backport at #8950. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This changes the
<h2>element in the participatory space subtitles to a<p>element as discussed at:#8893 (comment)
This makes it easier to control the heading orders below
<h1>and also makes it possible to fix some inconsistencies currently with the heading ordering, e.g. that the debate titles are<h2>but proposal titles are<h3>.The change is related to the rest of the accessibility fixes.
WCAG 2.2 / 1.3.1 Info and Relationships (Level A)
https://www.w3.org/TR/WCAG22/#info-and-relationships
https://www.w3.org/WAI/WCAG22/Understanding/info-and-relationships.html
📌 Related Issues
Testing
Take a look at the subtitle element with the inspector in different participatory spaces and see that it is now a
<p>.📋 Checklist
docs/.📷 Screenshots
The design is not affected by this change so the before and after looks the same: