Skip to content

Fix the component index views heading order for the subtitle change#8902

Merged
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/component-index-main-heading-order
Feb 24, 2022
Merged

Fix the component index views heading order for the subtitle change#8902
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/component-index-main-heading-order

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Feb 23, 2022

🎩 What? Why?

This fixes the component index views heading order after #8901 is applied.

I believe this can be merged already before #8901 because this shouldn't break the heading order (we'll see what CI says).

WCAG 2.2 / 1.3.1 Info and Relationships (Level A)

https://www.w3.org/TR/WCAG22/#info-and-relationships
https://www.w3.org/WAI/WCAG22/Understanding/info-and-relationships.html

📌 Related Issues

Testing

Go through the pages and see if they have the accessibility error for heading orders.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@andreslucena
Copy link
Copy Markdown
Member

I believe this can be merged already before #8901 because this shouldn't break the heading order (we'll see what CI says).

CI says it's all good, so I'll merge this

@andreslucena andreslucena merged commit d73c8cb into decidim:develop Feb 24, 2022
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@ahukkanen ahukkanen deleted the fix/component-index-main-heading-order branch February 24, 2022 08:12
@andreslucena andreslucena added team: accessibility type: fix PRs that implement a fix for a bug module: core labels Feb 25, 2022
@ahukkanen
Copy link
Copy Markdown
Contributor Author

Backport at #8950.

@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core team: accessibility type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants