Skip to content

Fix heading order in the process steps page#8906

Merged
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/process-steps-heading-order
Feb 24, 2022
Merged

Fix heading order in the process steps page#8906
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/process-steps-heading-order

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Feb 23, 2022

🎩 What? Why?

This fixes the illogical heading order at the process steps page. This also fixes an accessibility violation that would be added by #8901 without this change.

WCAG 2.2 / 1.3.1 Info and Relationships (Level A)

https://www.w3.org/TR/WCAG22/#info-and-relationships
https://www.w3.org/WAI/WCAG22/Understanding/info-and-relationships.html

📌 Related Issues

Testing

Check the process steps page heading order.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@andreslucena andreslucena merged commit 77a5c20 into decidim:develop Feb 24, 2022
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@ahukkanen ahukkanen deleted the fix/process-steps-heading-order branch February 24, 2022 08:11
ahukkanen added a commit to mainio/decidim that referenced this pull request Mar 2, 2022
@ahukkanen
Copy link
Copy Markdown
Contributor Author

Backport at #8950.

@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants