Conversation
Merged
Codecov Report
@@ Coverage Diff @@
## master #1784 +/- ##
==========================================
- Coverage 98.65% 98.58% -0.07%
==========================================
Files 1077 1115 +38
Lines 24412 24980 +568
==========================================
+ Hits 24083 24626 +543
- Misses 329 354 +25 |
This was referenced Aug 31, 2017
Closed
* Add Follow entity * Add Notification entity * Add Followable concern
* Publish update/close meeting events * Separate events from followable resources * Fix factory
* Create a notification for each follower when event is triggered * Make events dcide who will receive the notification * Add basic NotificationEvent module * Only create notifications if event_class supports them * Add event classes
* Make meeting events support emails * Send emails from events * Add default values for event emails * Fix specs * Fix rubocop issues * Customize email texts per event
* Add basic NotificationDashboard * Rename notification fields * Find participatory space manifest for processes and assemblies * Add read_at field to notifications * Notification titles i18n * Simplify notifications layout Remove unused pagination and filters * Mark notifications as read from UI * Add notifications link to user menu * Destroy notifications on read * Fix rubocop complaints * Paginate notifications * Mark all notifications as read * Improve JS code * Add tests for notification dashboard * Fix ivar name
4efe9d0 to
5868a77
Compare
oriolgual
approved these changes
Sep 7, 2017
This was referenced Sep 12, 2017
This was referenced Sep 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR lets users follow resources on Decidim and get notifications when an event occurs on these resources. To start, the only events published are:
So the users can only follow Meetings as of this PR.
This PR will receive other smaller PRs so the work is easier to review.
📌 Related Issues