Add notification dashboard#1788
Merged
mrcasals merged 15 commits intofeature/follow-resourcesfrom Sep 5, 2017
Merged
Conversation
Remove unused pagination and filters
Codecov Report
@@ Coverage Diff @@
## feature/follow-resources #1788 +/- ##
============================================================
+ Coverage 98.58% 98.58% +<.01%
============================================================
Files 1105 1107 +2
Lines 24743 24823 +80
============================================================
+ Hits 24392 24471 +79
- Misses 351 352 +1 |
9fcd5ce to
b584b86
Compare
beagleknight
suggested changes
Sep 5, 2017
|
|
||
| # Caches the path for the given resource. | ||
| def resource_path | ||
| @resource_url ||= resource_locator.path |
Contributor
There was a problem hiding this comment.
This should be @resource_path
beagleknight
approved these changes
Sep 5, 2017
beagleknight
pushed a commit
that referenced
this pull request
Sep 7, 2017
* Add basic NotificationDashboard * Rename notification fields * Find participatory space manifest for processes and assemblies * Add read_at field to notifications * Notification titles i18n * Simplify notifications layout Remove unused pagination and filters * Mark notifications as read from UI * Add notifications link to user menu * Destroy notifications on read * Fix rubocop complaints * Paginate notifications * Mark all notifications as read * Improve JS code * Add tests for notification dashboard * Fix ivar name
oriolgual
pushed a commit
that referenced
this pull request
Sep 7, 2017
* Add Follow & Notification models (#1780) * Add Follow entity * Add Notification entity * Add Followable concern * Send events (#1781) * Publish update/close meeting events * Separate events from followable resources * Fix factory * Create notifications (#1785) * Create a notification for each follower when event is triggered * Make events dcide who will receive the notification * Add basic NotificationEvent module * Only create notifications if event_class supports them * Add event classes * Send email on event (#1786) * Make meeting events support emails * Send emails from events * Add default values for event emails * Fix specs * Fix rubocop issues * Customize email texts per event * Add notification dashboard (#1788) * Add basic NotificationDashboard * Rename notification fields * Find participatory space manifest for processes and assemblies * Add read_at field to notifications * Notification titles i18n * Simplify notifications layout Remove unused pagination and filters * Mark notifications as read from UI * Add notifications link to user menu * Destroy notifications on read * Fix rubocop complaints * Paginate notifications * Mark all notifications as read * Improve JS code * Add tests for notification dashboard * Fix ivar name * Add follow button to UI (#1795) * Fix rubocop complains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR builds on top of #1786 and adds a notification dashboard for the user. Once the notification is set as read, the notification is destroyed, as discussed in #1692.
📌 Related Issues
📋 Subtasks