Skip to content

Fix displaying hidden meetings in homepage's "upcoming meetings" content block#8809

Merged
andreslucena merged 1 commit intodecidim:developfrom
i-need-another-coffee:ale-hide-meetings
Feb 15, 2022
Merged

Fix displaying hidden meetings in homepage's "upcoming meetings" content block#8809
andreslucena merged 1 commit intodecidim:developfrom
i-need-another-coffee:ale-hide-meetings

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Feb 14, 2022

🎩 What? Why?

Currently any Hidden meeting is being displayed on the upcomming meeting section on the homepage.

Testing

  1. As a regular user, create and publish a meeting in the future
  2. Go to homepage and observe that is being displayed in the upcoming meeting
  3. Report and Moderate (hide) that particular meeting
  4. Refresh the homepage and observe the meeting is not being displayed.

♥️ Thank you!

@andreslucena andreslucena added module: meetings type: fix PRs that implement a fix for a bug labels Feb 14, 2022
@andreslucena
Copy link
Copy Markdown
Member

Oh, I thought this was the fix for #8810, but I see that this is actually another issue… The fix for that one is #8811.

In my defense I have to say that they are both very similar, the two PRs are about moderated meetings visible 😅

@alecslupu
Copy link
Copy Markdown
Contributor Author

Yes, there are a few on the same topic.

@andreslucena andreslucena changed the title Do not display hidden meetings on homepage Fix displaying hidden meetings in homepage's "upcoming meetings" content block Feb 15, 2022
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've checked it locally and this works as expected. 👏🏽 👏🏽

@andreslucena andreslucena merged commit f4e4784 into decidim:develop Feb 15, 2022
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@alecslupu
Copy link
Copy Markdown
Contributor Author

Can you please backport to v0.26-stable 🙏🏽? Thanks

Check #8819

entantoencuanto added a commit that referenced this pull request Feb 18, 2022
* develop: (134 commits)
  Remove Rectify::Presenter references (#8758)
  Clarify the locales on the list of admins (#8838)
  Fix activity cell disappearing author images (#8826)
  Fix notifications when there is a note proposal in other spaces than processes (#8822)
  Fix accountability text search (#8831)
  Fix displaying hidden meetings in show process page (#8823)
  Fix docs for install-decidim.sh permissions (#8839)
  Fix report moderation for all the spaces (#8813)
  Clarify the comment at the resource search class (#8829)
  Fix displaying hidden related resources (#8812)
  Replace Decidim mentions in UI with 'the platform' (#8827)
  Add natively a .keep file to empty directory to include on git committing (#8830)
  Fix scope validation on initiative's creation (#8755)
  Replace `searchlight` with `ransack` which is already a core dependency (#8748)
  Fix characters not encoded in highlighted participatory process group title (#8820)
  Test ensuring the moderated comments are not computed in stats (#8816)
  Update rails to 6.0.4.6 and puma to 5.6.2 (#8817)
  Fix displaying hidden meetings in processes group's "upcoming meetings" content block (#8818)
  Fix displaying hidden meetings in homepage's "upcoming meetings" content block (#8809)
  Improve "Release Candidates" release docs (#8804)
  ...
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: meetings type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants