Skip to content

Fix displaying hidden meetings in show process page#8823

Merged
andreslucena merged 2 commits intodecidim:developfrom
i-need-another-coffee:fix/8821
Feb 17, 2022
Merged

Fix displaying hidden meetings in show process page#8823
andreslucena merged 2 commits intodecidim:developfrom
i-need-another-coffee:fix/8821

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Feb 15, 2022

🎩 What? Why?

This PR hides the hidden meetings from the show process page

📌 Related Issues

Link your PR to an issue

Testing

  1. From the show process page choose a meeting and report it
  2. Go to admin and hide it
  3. Revisit the show process page
  4. The Meeting should not be there anymore

♥️ Thank you!

@alecslupu alecslupu requested a review from roxanaopr February 15, 2022 13:46
roxanaopr
roxanaopr previously approved these changes Feb 15, 2022
@alecslupu alecslupu added module: participatory processes type: fix PRs that implement a fix for a bug labels Feb 15, 2022
@andreslucena andreslucena changed the title Fixing Hidden meetings are visible in show process page Fix displaying hidden meetings in show process page Feb 16, 2022
@alecslupu
Copy link
Copy Markdown
Contributor Author

@andreslucena This can be reviewd and merged is applicable.

Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny and cosmetic change

Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing else to say, thanks for your patience @alecslupu 😄

@andreslucena andreslucena merged commit 2be8e4c into decidim:develop Feb 17, 2022
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@alecslupu
Copy link
Copy Markdown
Contributor Author

@andreslucena done in #8843

entantoencuanto added a commit that referenced this pull request Feb 18, 2022
* develop: (134 commits)
  Remove Rectify::Presenter references (#8758)
  Clarify the locales on the list of admins (#8838)
  Fix activity cell disappearing author images (#8826)
  Fix notifications when there is a note proposal in other spaces than processes (#8822)
  Fix accountability text search (#8831)
  Fix displaying hidden meetings in show process page (#8823)
  Fix docs for install-decidim.sh permissions (#8839)
  Fix report moderation for all the spaces (#8813)
  Clarify the comment at the resource search class (#8829)
  Fix displaying hidden related resources (#8812)
  Replace Decidim mentions in UI with 'the platform' (#8827)
  Add natively a .keep file to empty directory to include on git committing (#8830)
  Fix scope validation on initiative's creation (#8755)
  Replace `searchlight` with `ransack` which is already a core dependency (#8748)
  Fix characters not encoded in highlighted participatory process group title (#8820)
  Test ensuring the moderated comments are not computed in stats (#8816)
  Update rails to 6.0.4.6 and puma to 5.6.2 (#8817)
  Fix displaying hidden meetings in processes group's "upcoming meetings" content block (#8818)
  Fix displaying hidden meetings in homepage's "upcoming meetings" content block (#8809)
  Improve "Release Candidates" release docs (#8804)
  ...
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hidden meetings are visible in "upcoming meetings" in process show page

3 participants